Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-71947

The indentation of the text must be corrected in the notice of time limit when starting a quiz

    XMLWordPrintable

Details

    • MOODLE_310_STABLE, MOODLE_311_STABLE, MOODLE_39_STABLE
    • MOODLE_310_STABLE, MOODLE_311_STABLE
    • MDL-71947-311
    • MDL-71947-master
    • Hide

      Test the quiz rule popup

      1. login as admin
      2. Create a new quiz, set the time limit to 2 minutes and set a password for the quiz
      3. Add a question to the quiz
      4. Attempt the quiz
      5. Verify you see a popup before you can start the attempt
      6. Verify the alignment for the popup looks similar to the screenshot below

      Test the vertical form

      1. add the attached formstest.php in your moodle root folder
      2. login as admin
      3. navigate to the /formstest.php file
      4. click the "Show vertical forms" link
      5. verify all form labels are now shown above the form field
      6. verify all label icons (exclamation / question mark) are shown connected to the form label

      expected result:

      Show
      Test the quiz rule popup login as admin Create a new quiz, set the time limit to 2 minutes and set a password for the quiz Add a question to the quiz Attempt the quiz Verify you see a popup before you can start the attempt Verify the alignment for the popup looks similar to the screenshot below Test the vertical form add the attached formstest.php in your moodle root folder login as admin navigate to the /formstest.php file click the "Show vertical forms" link verify all form labels are now shown above the form field verify all label icons (exclamation / question mark) are shown connected to the form label expected result:

    Description

      The indentation of the text in the modal of time limit when starting a timer quiz not displayed correctly.

      Steps to replicate

      1. Log in as an admin/teacher
      2. Create a course "Timer course"
      3. Create a quiz "Timed Quiz" , add 3-4 questions to the quiz.
      4. On the quiz setting page, enable a time limit of 2 minutes.
      5. Attempt/preview the quiz

      Observed behavior

      The text of the warning when entering the timed quiz does not occupy the entire width of the warning and the text is shifted to the right.

      Expected behavior

      The text of the warning when entering the timed quiz must occupy the entire width of the warning.

      What I found?

      I found that when using the "addElement" method of the MoodleQuickForm class, what is being done below is adding an HTML div tag with the CSS class of 'mod-col-3' with no content inside it, following this div another div is added with the CSS class of 'mod-col-9' in which the text is included.

      Attachments

        1. formstest.php
          12 kB
        2. MDL-71947.jpg
          MDL-71947.jpg
          46 kB
        3. mod_feedback_after.png
          mod_feedback_after.png
          727 kB
        4. mod_feedback_before.png
          mod_feedback_before.png
          721 kB
        5. screenshot-1.png
          screenshot-1.png
          34 kB
        6. screenshot-2.png
          screenshot-2.png
          62 kB
        7. Screenshot 2021-06-17 at 17.21.30.png
          Screenshot 2021-06-17 at 17.21.30.png
          315 kB
        8. Screenshot 2021-06-24 at 12.54.42.png
          Screenshot 2021-06-24 at 12.54.42.png
          120 kB
        9. screenshot-3.png
          screenshot-3.png
          147 kB
        10. vertical forms.png
          vertical forms.png
          745 kB

        Issue Links

          Activity

            People

              basbrands Bas Brands
              daniel.escobar Daniel Alejandro Escobar
              Tim Hunt Tim Hunt
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Anna Carissa Sadia Anna Carissa Sadia
              Tim Hunt, Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Stevani Andolo
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                12/Jul/21

                Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 6 hours, 10 minutes
                  6h 10m