Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-71991

file_system_filedir should check the return value of rename when writing files

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.10.4, 3.11
    • Fix Version/s: 3.10.5, 3.11.1
    • Component/s: Files API
    • Labels:

      Description

      This might help find possible causes of MDL-71990.

      The file API writes files to disc by first writing them with .tmp added to then name, and then doing a rename, which is more likely to be atomic. However, it does not check the return value of that rename call, which might be letter errors go unreported.

      So, adding in that error handling.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              timhunt Tim Hunt
              Reporter:
              timhunt Tim Hunt
              Peer reviewer:
              Brendan Heywood Brendan Heywood
              Integrator:
              Sara Arjona (@sarjona) Sara Arjona (@sarjona)
              Tester:
              CiBoT CiBoT
              Participants:
              Component watchers:
              Matteo Scaramuccia, Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                12/Jul/21

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 11 minutes
                  11m