[MDL-71991] file_system_filedir should check the return value of rename when writing files - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.10.4, 3.11
Fix Version/s: 3.10.5, 3.11.1
Component/s: Files API
Labels:
- ci

Affected Branches:
MOODLE_310_STABLE, MOODLE_311_STABLE
Fixed Branches:
MOODLE_310_STABLE, MOODLE_311_STABLE
Pull from Repository:
https://github.com/timhunt/moodle.git
Pull 3.11 Branch:
~~MDL-71991~~_311
Pull 3.11 Diff URL:
https://github.com/timhunt/moodle/compare/MOODLE_311_STABLE...MDL-71991_311
Pull Master Branch:
~~MDL-71991~~
Pull Master Diff URL:
https://github.com/timhunt/moodle/compare/master...MDL-71991
Testing Instructions:

Hide

This patch should have no effect. I cannot think of any way to test it directly (unless you are a wizard at simulating weird NFS behaviour.)

I think the main check is a full PHPunit + Behat run, to ensure it does not cause regressions.

Show
This patch should have no effect. I cannot think of any way to test it directly (unless you are a wizard at simulating weird NFS behaviour.) I think the main check is a full PHPunit + Behat run, to ensure it does not cause regressions.

Description

This might help find possible causes of MDL-71990.

The file API writes files to disc by first writing them with .tmp added to then name, and then doing a rename, which is more likely to be atomic. However, it does not check the return value of that rename call, which might be letter errors go unreported.

So, adding in that error handling.

Attachments

Issue Links

Testing discovered

MDL-72026 Race conditions writing tmp files in file system filedir

Waiting for peer review

will be (partly) resolved by

MDL-70243 Add a file system performance summary into the footer and file IO debug mode

Development in progress

will help resolve

MDL-71990 File API seems to be capable of silently losing files (very rarely)

Open

Activity

People

Assignee:: Tim Hunt

Reporter:: Tim Hunt

Peer reviewer:: Brendan Heywood

Integrator:: Sara Arjona (@sarjona)

Tester:: CiBoT

Participants:: Brendan Heywood, CiBoT, Ilya Tregubov, Sara Arjona (@sarjona), Tim Hunt

Component watchers:: Matteo Scaramuccia, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 1 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 22/Jun/21 9:06 PM

Updated:: 01/Jul/21 11:45 PM

Resolved:: 01/Jul/21 11:45 PM

Fix Release Date:: 12/Jul/21

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

11m