[MDL-72025] Memory error during 3.11 upgrade - user_profile_social_update_module_availability() - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.11, 4.0
Fix Version/s: 3.11.3
Component/s: User management
Labels:
- ci
- regression
- triaged

Affected Branches:
MOODLE_311_STABLE, MOODLE_400_STABLE
Fixed Branches:
MOODLE_311_STABLE
Pull from Repository:
https://github.com/sammarshallou/moodle.git
Pull 3.11 Branch:
~~MDL-72025~~-m311
Pull 3.11 Diff URL:
https://github.com/sammarshallou/moodle/compare/MOODLE_311_STABLE...MDL-72025-m311
Pull Master Branch:
~~MDL-72025~~-master
Pull Master Diff URL:
https://github.com/sammarshallou/moodle/compare/master...MDL-72025-master
Testing Instructions:
Hide

It probably isn't feasible to recreate the actual memory error while testing, so here are testing instructions to confirm the upgrade step still works after the change:

Install Moodle 3.10.x.

Create a course.

Add an activity module. Using the 'Restrict access' section of the settings form, add a 'User profile field' condition on the 'ICQ' field being 'frog',

Upgrade your site to Moodle 3.11+ (including this change).

Look at the activity module and verify that it still has a user profile field condition on the ICQ field being 'frog'.

For a 'real' test, I tested on our system that had this problem before the change (~650k course_modules entries of which ~50k actually have an availability set) and it ran through the upgrade step quickly (1.5 seconds).
Show
It probably isn't feasible to recreate the actual memory error while testing, so here are testing instructions to confirm the upgrade step still works after the change: Install Moodle 3.10.x. Create a course. Add an activity module. Using the 'Restrict access' section of the settings form, add a 'User profile field' condition on the 'ICQ' field being 'frog', Upgrade your site to Moodle 3.11+ (including this change). Look at the activity module and verify that it still has a user profile field condition on the ICQ field being 'frog'. For a 'real' test, I tested on our system that had this problem before the change (~650k course_modules entries of which ~50k actually have an availability set) and it ran through the upgrade step quickly (1.5 seconds).

Description

We are testing an upgrade to Moodle 3.11 and we're getting a memory exhausted error in user_profile_social_update_module_availability().

We can increase the memory limits but I think this can easily be fixed in the code.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

MDL-72025_Test Passed.PNG
15 kB
08/Sep/21 5:54 PM

Issue Links

Discovered while testing

MDL-28452 Convert user profile fields for messaging/networking into custom profile fields

Closed

has a non-specific relationship to

MDL-60174 get_recordset methods load entire result set into memory in Postgres

Closed

MDL-63315 Cursor already declared DB errors with Postgres

Closed

is duplicated by

MDL-72465 Moodle 3.11 upgrade runs out of memory on large system

Closed

Activity

People

Assignee:: Sam Marshall

Reporter:: Juan Segarra Montesinos

Peer reviewer:: Katie Ransom

Integrator:: Eloy Lafuente (stronk7)

Tester:: Gladys Basiana

Participants:: CiBoT, Eloy Lafuente (stronk7), Gladys Basiana, Jordan Tomkinson, Juan Segarra Montesinos, Katie Ransom, Luca Bösch, Matteo Scaramuccia, Neill Magill, Sam Marshall, Tim Hunt

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 4 Vote for this issue

Watchers:: 13 Start watching this issue

Dates

Created:: 26/Jun/21 12:27 PM

Updated:: 11/Sep/21 6:48 PM

Resolved:: 11/Sep/21 6:48 PM

Fix Release Date:: 13/Sep/21

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

2h 50m