Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Critical
Fix Version/s: 4.4.8, 4.5.4
Affects Version/s: 3.5.18, 3.9.7, 3.10.4, 3.11, 4.0.8, 4.1.3, 4.2, 4.4.7, 4.5, 4.5.1, 5.0
Component/s: Files API
Labels:
- ci
- mebis
- triaged

Affected Branches:
MOODLE_310_STABLE, MOODLE_311_STABLE, MOODLE_35_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE, MOODLE_401_STABLE, MOODLE_402_STABLE, MOODLE_404_STABLE, MOODLE_405_STABLE, MOODLE_500_STABLE
Fixed Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Pull from Repository:
https://github.com/sh-csg/moodle/
Pull 4.4 Branch:
~~MDL-72050~~-404
Pull 4.4 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_404_STABLE...sh-csg:moodle:MDL-72050-404
Pull 4.5 Branch:
~~MDL-72050~~-405
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...sh-csg:moodle:MDL-72050-405
Pull Main Branch:
~~MDL-72050~~-main
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...sh-csg:moodle:MDL-72050-main
Testing Instructions:
Hide

Create a course

Go to Questionbank -> Import

Import the file Qs with lots of images-1.xml

Repeat step 2 and 3

Confirm, the second upload works without errors.
Show
Create a course Go to Questionbank -> Import Import the file Qs with lots of images-1.xml Repeat step 2 and 3 Confirm, the second upload works without errors.
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-72050~~ using repository: https://github.com/sh-csg/moodle/

MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-72050-404 | CI Job]

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-72050-405 | CI Job]

main (0 errors / 0 warnings) [branch: MDL-72050-main | CI Job]

_{More information about this report}

Built on: Fri Mar 7 06:25:05 UTC 2025
Show
Code verified against automated checks. Checked MDL-72050 using repository: https://github.com/sh-csg/moodle/ MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-72050-404 | CI Job ] MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-72050-405 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-72050-main | CI Job ] More information about this report Built on: Fri Mar 7 06:25:05 UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-72050~~-404

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18458/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63215/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63216/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-72050~~-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18459/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63217/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63218/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-72050~~-main

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18460/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63219/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63220/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63221/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63222/ App tests (stable app version) --> unrelated failure, please ignore.

Built on: Fri Mar 7 06:25:21 UTC 2025
Show
Launching automatic jobs for branch MDL-72050 -404 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18458/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63215/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63216/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-72050 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18459/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63217/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63218/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-72050 -main https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18460/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63219/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63220/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63221/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/63222/ App tests (stable app version) --> unrelated failure, please ignore. Built on: Fri Mar 7 06:25:21 UTC 2025

The heuristic added in MDL-69028 is not very good, and can block legitimate users.

Stepts to reproduce:

Go to: https://tjh238.vledev3.open.ac.uk/moodle_head/question/import.php?courseid=2
Import the attached file: Qs with lots of images.xml (which is Moodle XML format).
Go to: Go to: https://tjh238.vledev3.open.ac.uk/moodle_head/question/import.php?courseid=2
Try to add the file to the form again.*

Expected result: you can (obviously, in real use, you are more likely to want to upload a different file the second time, but for our testing, using the same file twice should be fine.)

Actual result: The file upload is blocked with pop-up message "Your file uploads are temporarily limited after you uploaded a high volume of files. Please wait then try again."

That's odd, so far, I have only uploaded 2 files, right?

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

image-2022-07-27-15-10-02-462.png
32 kB
28/Jul/22 5:10 AM
MDL-72050.png
192 kB
03/Apr/25 10:07 AM
Qs with lots of images.xml
1011 kB
30/Jun/21 6:11 PM
Qs with lots of images-1.xml
1011 kB
19/Feb/25 3:30 PM

is duplicated by

MDL-85142 File upload limited temporarily in database activity

Waiting for peer review

Assignee:: Stefan Hanauska

Reporter:: Tim Hunt

Peer reviewer:: Tim Hunt

Integrator:: Shamim Rezaie

Tester:: Ron Carl Alfon Yu

Participants:: Andrew Lyons, Berengar W. Lehr, Caleb Marfell, CiBoT, David Cardiff, Doug Stevens, Eloy Lafuente (stronk7), Katrin Lee, Matthias Giger, Michael Milette, Nicolas Mouillet, Ron Carl Alfon Yu, Shamim Rezaie, Stefan Hanauska, Tim Hunt

Votes:: 30 Vote for this issue

Watchers:: 33 Start watching this issue

Created:: 30/Jun/21 6:11 PM

Updated:: 1 week ago 2:47 PM

Resolved:: 04/Apr/25 11:43 PM

Estimated:

Not Specified

Remaining:

Logged:

1h 38m

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify