Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-72085

Clean $SESSION->notifications when resetting after a unit test

    XMLWordPrintable

    Details

      Description

      Data privacy tool doesn't clean up notifications from the SESSION object after some tests.

       

       

      bin/moodle-docker-compose exec webserver vendor/bin/phpunit --testsuite local_helper_testsuite,tool_dataprivacy_testsuite
      Moodle 4.0dev (Build: 20210701), 3610f1ee3b3da37140a7641af602bb5e3c8ba1bb
      Php: 7.4.19, pgsql: 11.11 (Debian 11.11-1.pgdg90+1), OS: Linux 5.8.0-59-generic x86_64
      PHPUnit 9.5.4 by Sebastian Bergmann and contributors.
      ............................................................... 63 / 306 ( 20%)
      ............................................................... 126 / 306 ( 41%)
      ............................................................... 189 / 306 ( 61%)
      ............................................................... 252 / 306 ( 82%)
      .....................................................F 306 / 306 (100%)
      Time: 00:42.913, Memory: 113.00 MB
      There was 1 failure:
      1) local_helper\tests\dummy_test::test_session_termination
      Failed asserting that an array is empty.
      /var/www/html/local/helper/tests/dummy_test.php:48
      /var/www/html/lib/phpunit/classes/advanced_testcase.php:80
      FAILURES!
      Tests: 306, Assertions: 1210, Failures: 1.
      

       

       

        Attachments

          Activity

            People

            Assignee:
            dmitriim Dmitrii Metelkin
            Reporter:
            dmitriim Dmitrii Metelkin
            Peer reviewer:
            Mikhail Golenkov Mikhail Golenkov
            Integrator:
            Víctor Déniz Falcón Víctor Déniz Falcón
            Tester:
            Gladys Basiana Gladys Basiana
            Participants:
            Component watchers:
            Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              13/Sep/21

                Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 30 minutes
                1h 30m