Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-72098

deprecate grade_grade::insert method that just calls its parent

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.9.7
    • Fix Version/s: None
    • Component/s: Gradebook, Grading methods
    • Labels:

      Description

      Looks like this should of be done ages ago.

      This method grade_grade.php #1030 just calls grade_object.php #339

      So the method grade_object:insert override was done in March 2008 (commit 'MDL-12182 Fixing unit tests for gradebook. Mainly a change in set_locked() arguments. Merging from MOODLE_19_STABLE'). And then the only line that made that function different was commented few days later (commit message 'MDL-13899 feedback itself is a type of grading - date graded is now affected by feedback too; merged from MOODLE_19_STABLE'). So by the look of things this extra method could be removed ... in March 2008

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              ilyatregubov Ilya Tregubov
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated: