Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-72134

Ability to subscribe to drawer events without initialisation

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Reopened
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 4.0
    • Fix Version/s: None
    • Component/s: Navigation
    • Testing Instructions:
      Hide
      1. Login as an admin
      2. Go to a course page
      3. Change the size of a browser to be about 1177x963 with the original side bar expanded
      4. Expand the blocks drawer
      5. Confirm the number of moremenu tabs are decreased
      6. Hide the blocks drawer
      7. Confirm the number of moremenu tabs are increased

      Retest drawers

      1. Go to a course page
      2. Click on the block drawer
      3. Confirm the drawer expands and shows blocks
      Show
      Login as an admin Go to a course page Change the size of a browser to be about 1177x963 with the original side bar expanded Expand the blocks drawer Confirm the number of moremenu tabs are decreased Hide the blocks drawer Confirm the number of moremenu tabs are increased Retest drawers Go to a course page Click on the block drawer Confirm the drawer expands and shows blocks
    • Affected Branches:
      MOODLE_400_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-72134-master
    • Story Points:
      1
    • Sprint:
      Navigation push 4

      Description

      Secondary nav does not autoCollapse, when the page content has been resized. The autoCollapse is only hooked into the window resize, however in cases when the page is already loaded but the page width changes, then the resize is not handled.

      e.g. With the existing sidebar you can change the width of the page but this is not being handled.

      We will have to account for this considering the course index bar and block bar which is going to come in (MDL-71209).

      Please pull in the branch mentioned above and:

      1. Get the primary and secondary navigation to show up in the course page.
      2. Look at the autoCollapse of the secondary navigation when toggling the course index list and the block drawer.

      There is currently no way to subscribe to drawer events without forcing the drawer to go through it's initialisation process. This is not always required when there are shared files across multiple pages that may not have the drawer present.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              peterdias Peter Dias
              Reporter:
              peterdias Peter Dias
              Peer reviewer:
              Mathew May Mathew May
              Integrator:
              Adrian Greeve Adrian Greeve
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 4 hours, 50 minutes
                  4h 50m