[MDL-72135] Remove superfluous rand call from mnet cron - Moodle Tracker

XML

Word

Printable

Details

Type: Improvement
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 4.0
Fix Version/s: 4.0
Component/s: MNet, Tasks
Labels:
- CatalystIT
- ci
- partner
- triaged

Affected Branches:
MOODLE_400_STABLE
Fixed Branches:
MOODLE_400_STABLE
Pull from Repository:
https://github.com/golenkovm/moodle
Pull Master Branch:
~~MDL-72135~~-master
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/036800d99debfe...golenkovm:MDL-72135-master
Testing Instructions:
Hide

Run the task from the CLI

php admin/cli/scheduled_task.php --execute='\auth_mnet\task\cron_task'

Confirm, that you don't get any error or debugging.

Login as admin.

Go to Site administration > Server > Tasks > Scheduled tasks.

Search for mnet.

Confirm, that the task is scheduled to run every 10 mins.
Show
Run the task from the CLI php admin/cli/scheduled_task.php --execute= '\auth_mnet\task\cron_task' Confirm , that you don't get any error or debugging. Login as admin. Go to Site administration > Server > Tasks > Scheduled tasks. Search for mnet . Confirm , that the task is scheduled to run every 10 mins.

Description

It seems like this rand() is not really needed and can be removed:

https://github.com/moodle/moodle/blob/c3577797226da11e21a0ad5c61394acc239bd9c7/auth/mnet/classes/task/cron_task.php#L47

As I found it comes from 2007:

https://github.com/moodle/moodle/commit/4c1c5d2638747cdbfd6c449873831045d2086547

Attachments

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

MDL-72135_Test Passed.png
73 kB
19/Aug/21 11:54 AM

Activity

People

Assignee:: Misha Golenkov

Reporter:: Misha Golenkov

Peer reviewer:: Mark Nelson

Integrator:: Andrew Lyons

Tester:: Gladys Basiana

Participants:: Andrew Lyons, CiBoT, Gladys Basiana, Mark Nelson, Misha Golenkov, Sara Arjona (@sarjona)

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 6 Start watching this issue

Dates

Created:: 12/Jul/21 2:10 PM

Updated:: 20/Aug/21 7:57 PM

Resolved:: 20/Aug/21 7:57 PM

Fix Release Date:: 19/Apr/22

Time Tracking

Estimated:

Not Specified

Remaining:

0m

Logged:

25m