Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-72139

Encoding is lost after upgrading 3.9 to 3.9.8

    XMLWordPrintable

    Details

    • Affected Branches:
      MOODLE_310_STABLE, MOODLE_311_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE
    • Fixed Branches:
      MOODLE_310_STABLE, MOODLE_311_STABLE, MOODLE_39_STABLE
    • Pull 3.9 Branch:
    • Pull 3.10 Branch:
      MDL-72139-310
    • Pull 3.11 Branch:
      MDL-72139-311
    • Pull Master Branch:
      MDL-72139-master
    • Testing Instructions:
      Hide
      1. You shoud have a Moodle with two students and both students have email notifications enabled for messages (you can access as admin to "Site administration > Messaging > Notification settings" and then enable Online and Offline "Personal messages between users "in the Email column).
      2. Open mailhog, mailcatcher or similar tool configured to capture emails from your Moodle site (or set one up). Note: Don't test it using Gmail. It works fine with and without the patch.
      3. Log in as student 1.
      4. Send student 2 this message, eg "Hello, السلام عليكم".
      5. Open mailhog and CONFIRM that you see the same message, including "This is a copy of a message ..." message at the end.
      6. Send student 2 another message, this time with some HTML and ending with an opening HTML comment, eg:

        <h1>Important message from Moodle</h1>
        <img src="https://moodle.org/theme/image.php/moodleorg/theme_moodleorg/1621925120/moodle_logo_small"><!--

      7. Check Mailhog and CONFIRM the "This is a copy of a message..." text is visible.

       

      Show
      You shoud have a Moodle with two students and both students have email notifications enabled for messages (you can access as admin to "Site administration > Messaging > Notification settings" and then enable Online and Offline "Personal messages between users "in the Email column). Open mailhog, mailcatcher or similar tool configured to capture emails from your Moodle site (or set one up). Note: Don't test it using Gmail. It works fine with and without the patch. Log in as student 1. Send student 2 this message, eg "Hello, السلام عليكم". Open mailhog and CONFIRM that you see the same message, including "This is a copy of a message ..." message at the end. Send student 2 another message, this time with some HTML and ending with an opening HTML comment, eg: <h1>Important message from Moodle</h1> <img src="https://moodle.org/theme/image.php/moodleorg/theme_moodleorg/1621925120/moodle_logo_small"><!-- Check Mailhog and CONFIRM the "This is a copy of a message..." text is visible.  
    • Sprint:
      Moppies Kanban

      Description

      UTF-8 encoding is lost after upgrading Moodle 3.9.7+ (Build: 20210617) to Moodle 3.9.8 (Build: 20210712) | Version 2020061508 | Stable version.

      All emails are sent with wrong page encoding resulting in non readable email notifications

        Attachments

        1. issuepdf
          36 kB
        2. mailcatcher_screenshot.png
          mailcatcher_screenshot.png
          72 kB
        3. MDL-72139.jpg
          MDL-72139.jpg
          42 kB
        4. reproduced_mailcatcher.png
          reproduced_mailcatcher.png
          35 kB

          Activity

            People

            Assignee:
            cescobedo Carlos Escobedo
            Reporter:
            ali.alhaidary Ali Alhaidary
            Peer reviewer:
            Sara Arjona (@sarjona) Sara Arjona (@sarjona)
            Integrator:
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Tester:
            Anna Carissa Sadia Anna Carissa Sadia
            Participants:
            Component watchers:
            Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              29/Jul/21

                Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 3 hours, 30 minutes
                3h 30m