[MDL-72153] Privacy export of user data doesn't export description files correctly/triggers debugging - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.11.1
Fix Version/s: 3.10.7, 3.11.3
Component/s: Privacy, User management
Labels:
- ci
- release_notes
- triaged

Affected Branches:
MOODLE_311_STABLE
Fixed Branches:
MOODLE_310_STABLE, MOODLE_311_STABLE
Pull from Repository:
git://github.com/paulholden/moodle.git
Pull 3.11 Branch:
~~MDL-72153~~-311
Pull 3.11 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_311_STABLE...paulholden:MDL-72153-311
Pull Master Branch:
~~MDL-72153~~
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...paulholden:MDL-72153
Testing Instructions:
Hide

Login as admin

Select Profile from user menu

Press Edit profile

Add an image to the Description field (easiest to choose one from the Wikimedia repository)

Download the privacy-export.php file from this issue and place it in the moodle directory for the branch being tested

Run the following command:

$ php privacy-export.php --userid=2

Confirm there is no debugging in the output regarding use of format_text, when processing core_user component

Open exported index file

Navigate to User Admin User > data.json

Confirm the image you added to your profile description is displayed in the description field
Show
Login as admin Select Profile from user menu Press Edit profile Add an image to the Description field (easiest to choose one from the Wikimedia repository) Download the privacy-export.php file from this issue and place it in the moodle directory for the branch being tested Run the following command: $ php privacy-export.php --userid=2 Confirm there is no debugging in the output regarding use of format_text , when processing core_user component Open exported index file Navigate to User Admin User > data.json Confirm the image you added to your profile description is displayed in the description field

Description

When exporting data for a user using the privacy tool, for a user whose description field contains files (e.g. embedded images) - the file link is broken in the exported archive when viewing the user data

The following debugging notice is also triggered during the export process:

    Processing core_user (26/27) (Wednesday, 14 July 2021, 8:43 PM)

++ Before calling format_text(), the content must be processed with file_rewrite_pluginfile_urls() ++

* line 1347 of /lib/weblib.php: call to debugging()

* line 379 of /user/classes/privacy/provider.php: call to format_text()

* line 222 of /user/classes/privacy/provider.php: call to core_user\privacy\provider::export_user()

* line 8010 of /lib/moodlelib.php: call to core_user\privacy\provider::export_user_data()

* line 578 of /privacy/classes/manager.php: call to component_class_callback()

* line 611 of /privacy/classes/manager.php: call to core_privacy\manager::component_class_callback()

* line 339 of /privacy/classes/manager.php: call to core_privacy\manager->handled_component_class_callback()

* line 79 of /privacy-export.php: call to core_privacy\manager->export_user_data()

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

MDL-72153_Test Passed.png
763 kB
26/Aug/21 5:26 PM
privacy-export.php
3 kB
26/Aug/21 11:33 AM

Activity

People

Assignee:: Paul Holden

Reporter:: Paul Holden

Peer reviewer:: Simey Lameze

Integrator:: Andrew Lyons

Tester:: Gladys Basiana

Participants:: Andrew Lyons, CiBoT, Gladys Basiana, Paul Holden, Simey Lameze

Component watchers:: Andrew Lyons, Adrian Greeve, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 15/Jul/21 3:45 AM

Updated:: 07/Sep/21 9:35 PM

Resolved:: 27/Aug/21 3:33 PM

Fix Release Date:: 13/Sep/21

Time Tracking

Estimated:

Remaining:

Logged:

1h 48m