Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-72158

Remove unit tests customisation from aggregate_completions

    XMLWordPrintable

Details

    • Task
    • Status: Open
    • Minor
    • Resolution: Unresolved
    • 4.0
    • None
    • Course completion
    • MOODLE_400_STABLE

    Description

      In MDL-32103 we added these line for tests:

              if (PHPUNIT_TEST) {
                  // MDL-33320: for instant completions we need aggregate to work in a single run.
                  $DB->set_field('course_completions', 'reaggregate', $timestarted - 2);
              }
      

      As we need cron to work on first run. Its safer to do what Behat does at the moment and just run cron twice and wait 1 sec between runs. Not ideal, but at least it is not change completion date by direct sql

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              ilyatregubov Ilya Tregubov
              Amaia Anabitarte, Bas Brands, Carlos Escobedo, Laurent David, Raquel Ortega, Sabina Abellan, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated: