Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-72186

Incomplete forum web service removal breaks WS API docs

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 4.0
    • Fix Version/s: 4.0
    • Component/s: Forum, Web Services
    • Labels:
    • Testing Instructions:
      Hide
      1. Checkout commit prior to MDL-65252, e.g.

        $ git checkout 3610f1ee3b
        

      2. Install site
      3. Checkout the changes in this branch

        $ git checkout master
        

      4. Run upgrade process
      5. Navigate to Server > Web services > API documentation in site administration
      6. Confirm page loads without exceptions
      Show
      Checkout commit prior to MDL-65252 , e.g. $ git checkout 3610f1ee3b Install site Checkout the changes in this branch $ git checkout master Run upgrade process Navigate to Server > Web services > API documentation in site administration Confirm page loads without exceptions
    • Affected Branches:
      MOODLE_400_STABLE
    • Fixed Branches:
      MOODLE_400_STABLE
    • Pull Master Branch:

      Description

      This is caused by MDL-65252 removing a web service method but not bumping the version number for mod_forum, which would have triggered the removal of said service from the external_functions table

      Leads to the following error:

      Coding error detected, it must be fixed by a programmer: Missing implementation method mod_forum_external::get_forum_discussion_posts
       
      More information about this error
      Debug info:
      Error code: codingerror
      Stack trace:
       
          line 103 of /lib/externallib.php: coding_exception thrown
          line 36 of /admin/webservice/documentation.php: call to external_api::external_function_info()
      

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              pholden Paul Holden
              Reporter:
              pholden Paul Holden
              Peer reviewer:
              Amaia Anabitarte Amaia Anabitarte
              Integrator:
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Tester:
              Gladys Basiana Gladys Basiana
              Participants:
              Component watchers:
              Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Juan Leyva, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                13/Dec/21

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 10 minutes
                  1h 10m