Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-72207

Webservice mod_assign_get_submission_status doesn't support "All participants"

    XMLWordPrintable

Details

    • MOODLE_310_STABLE, MOODLE_311_STABLE
    • MOODLE_310_STABLE, MOODLE_311_STABLE
    • MDL-72207-311
    • MDL-72207-master
    • Hide
      Prerequisite
      1. Moodle mobile app.
      2. Your Moodle mobile app should be able to connect to your Moodle website. You can either do the following:
        • Ensure that the phone with the mobile app and the web server are on the same network. Or
        • Expose the web server over the internet via ngrok.
      Test
      1. As admin, enable "Mobile services": Site administration ► Mobile app ► Mobile settings
      2. Create a new course configured to use "Separated groups" forced
      3. Create two groups withing the course with the following names: g1 and g2
      4. Enrol 4 users as students in the course, u1, u2, u3 and u4
      5. Enrol u1 and u2 into group g1.
      6. Enrol u3 and u4 into group g2
      7. Enrol another user as editing teacher in the course (do not assign any group to this user)
      8. Create a new assignment activity with its default configuration
      9. Now, with the teacher user, access to the assignment activity via the Mobile app
      10. Confirm that:
        • When selecting "All users" you see a 4 at the right of the participants row
        • When selecting g1 or g2 you only see 2 participants in the same row
      Show
      Prerequisite Moodle mobile app. Your Moodle mobile app should be able to connect to your Moodle website. You can either do the following: Ensure that the phone with the mobile app and the web server are on the same network. Or Expose the web server over the internet via ngrok. Test As admin, enable "Mobile services": Site administration ► Mobile app ► Mobile settings Create a new course configured to use "Separated groups" forced Create two groups withing the course with the following names: g1 and g2 Enrol 4 users as students in the course, u1, u2, u3 and u4 Enrol u1 and u2 into group g1. Enrol u3 and u4 into group g2 Enrol another user as editing teacher in the course (do not assign any group to this user) Create a new assignment activity with its default configuration Now, with the teacher user, access to the assignment activity via the Mobile app Confirm that: When selecting "All users" you see a 4 at the right of the participants row When selecting g1 or g2 you only see 2 participants in the same row

    Description

      According the the documentation of the groupid param:

      "Empty or 0 for all groups information."

      However, in the Webservice code the groupid is converted to null if it's empty. Then, the function get_assign_grading_summary_renderable calculates the current group if groupid is null, so the WebService ends up returning information of a certain group instead of all participants.

      Attachments

        1. screenshot-1.png
          screenshot-1.png
          83 kB
        2. screenshot-2.png
          screenshot-2.png
          85 kB
        3. MDL-72207_All Users.PNG
          MDL-72207_All Users.PNG
          337 kB
        4. MDL-72207_g1.PNG
          MDL-72207_g1.PNG
          196 kB
        5. MDL-72207_g2.PNG
          MDL-72207_g2.PNG
          243 kB

        Issue Links

          Activity

            People

              jleyva Juan Leyva
              dpalou Dani Palou
              Dani Palou Dani Palou
              Andrew Lyons Andrew Lyons
              Angelia Dela Cruz Angelia Dela Cruz
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Sujith Haridasan, Juan Leyva, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Laurent David, Raquel Ortega, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                13/Sep/21

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 30 minutes
                  1h 30m