Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-72242

Missing SVG files in forum posts

    XMLWordPrintable

Details

    • MOODLE_310_STABLE, MOODLE_311_STABLE, MOODLE_400_STABLE
    • MOODLE_310_STABLE, MOODLE_311_STABLE
    • MDL-72242-311-svgforcedfilter
    • MDL-72242-master-svgforcedfilter
    • Hide
      1. Download the Moodle SVG logo from Wikimedia - https://commons.wikimedia.org/wiki/File:Moodle-logo.svg (make sure you actually save the "Original file" in SVG format, not a PNG preview.
      2. Log in as the site admin
      3. Go to Site administration > Plugins > Filters > Manage filters
      4. Enable the "Word censorship"
      5. Go to "Word censorship" settings
      6. Add <svg (including the less-than character at the start) into the Custom bad words list
      7. Go to a forum and add a new post
      8. Insert image to the post message and upload the Moodle logo SVG (note: you may need to disable the "Auto size" checkbox and manually type size like 200x50 as there seems to be another problem with detecting SVG size).
      9. Save the post
      10. TEST Check that you actually see the Moodle logo image in the post.
      Show
      Download the Moodle SVG logo from Wikimedia - https://commons.wikimedia.org/wiki/File:Moodle-logo.svg (make sure you actually save the "Original file" in SVG format, not a PNG preview. Log in as the site admin Go to Site administration > Plugins > Filters > Manage filters Enable the "Word censorship" Go to "Word censorship" settings Add <svg (including the less-than character at the start) into the Custom bad words list Go to a forum and add a new post Insert image to the post message and upload the Moodle logo SVG (note: you may need to disable the "Auto size" checkbox and manually type size like 200x50 as there seems to be another problem with detecting SVG size). Save the post TEST Check that you actually see the Moodle logo image in the post.

    Description

      It looks like *.svg aren't rendering anymore in forum posts.

      These posts are an example: https://moodle.org/mod/forum/discuss.php?d=417599#p1688163 and https://moodle.org/mod/forum/discuss.php?d=417599#p1683186

      It references this svg: https://moodle.org/pluginfile.php/134/mod_forum/post/1682674/Moodle%20question%20system.svg Which if you access it directly "looks" corrupted

      Attachments

        1. after_patch.png
          after_patch.png
          8 kB
        2. before_patch.png
          before_patch.png
          8 kB
        3. MDL-72242_integration test.png
          MDL-72242_integration test.png
          48 kB
        4. MDL-72242_v3.10 test.png
          MDL-72242_v3.10 test.png
          50 kB
        5. MDL-72242_v3.11 test.png
          MDL-72242_v3.11 test.png
          49 kB

        Issue Links

          has a non-specific relationship to

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDLSITE-6552 SVG images in moodle.org forum posts have broken

          • High - Customer/Partner Issue, GDPR removal, priority Features
          • Resolved
          is a regression caused by

          Improvement - An enhancement to an existing Moodle feature. MDL-55243 SVG files are images and should be allowed for course images, drag-drop questions, etc.

          • Minor - Minor loss of function where workaround is possible
          • Closed
          Testing discovered

          Task - A task that needs to be completed. Tasks usually refer to work that must be done outside the product. MDL-72336 Review filter_censor behaviors and cover it with unit tests

          • Major - Major loss of function, incorrect output
          • Open
          will help resolve

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-72294 Some H5P icons are broken in content bank drop down

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              mudrd8mz David Mudrák (@mudrd8mz)
              mattp@catalyst-au.net Matt Porritt
              Tim Hunt Tim Hunt
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Angelia Dela Cruz Angelia Dela Cruz
              Matteo Scaramuccia, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, Adrian Greeve, Ilya Tregubov, Kevin Percy, Mathew May, Mihail Geshoski, Shamim Rezaie
              Votes:
              5 Vote for this issue
              Watchers:
              13 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                13/Sep/21

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 4 hours, 11 minutes
                  4h 11m