Loading...

XML

Word

Printable

Details

Type: Bug
Resolution: Fixed
Priority: Major
Fix Version/s: 3.10.7, 3.11.3
Affects Version/s: 3.10.6, 3.11.1, 4.0
Component/s: Files API, Forum
Labels:
- ci
- regression
- release_notes
- triaged

Affected Branches:
MOODLE_310_STABLE, MOODLE_311_STABLE, MOODLE_400_STABLE
Fixed Branches:
MOODLE_310_STABLE, MOODLE_311_STABLE
Pull from Repository:
git://github.com/mudrd8mz/moodle.git
Pull Main Branch:
~~MDL-72242~~-master-svgforcedfilter
Pull Main Diff URL:
https://github.com/mudrd8mz/moodle/compare/dc437b5171...MDL-72242-master-svgforcedfilter
Testing Instructions:
Hide

Download the Moodle SVG logo from Wikimedia - https://commons.wikimedia.org/wiki/File:Moodle-logo.svg (make sure you actually save the "Original file" in SVG format, not a PNG preview.

Log in as the site admin

Go to Site administration > Plugins > Filters > Manage filters

Enable the "Word censorship"

Go to "Word censorship" settings

Add <svg (including the less-than character at the start) into the Custom bad words list

Go to a forum and add a new post

Insert image to the post message and upload the Moodle logo SVG (note: you may need to disable the "Auto size" checkbox and manually type size like 200x50 as there seems to be another problem with detecting SVG size).

Save the post

TEST Check that you actually see the Moodle logo image in the post.
Show
Download the Moodle SVG logo from Wikimedia - https://commons.wikimedia.org/wiki/File:Moodle-logo.svg (make sure you actually save the "Original file" in SVG format, not a PNG preview. Log in as the site admin Go to Site administration > Plugins > Filters > Manage filters Enable the "Word censorship" Go to "Word censorship" settings Add <svg (including the less-than character at the start) into the Custom bad words list Go to a forum and add a new post Insert image to the post message and upload the Moodle logo SVG (note: you may need to disable the "Auto size" checkbox and manually type size like 200x50 as there seems to be another problem with detecting SVG size). Save the post TEST Check that you actually see the Moodle logo image in the post.

Description

It looks like *.svg aren't rendering anymore in forum posts.

These posts are an example: https://moodle.org/mod/forum/discuss.php?d=417599#p1688163 and https://moodle.org/mod/forum/discuss.php?d=417599#p1683186

It references this svg: https://moodle.org/pluginfile.php/134/mod_forum/post/1682674/Moodle%20question%20system.svg Which if you access it directly "looks" corrupted

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

after_patch.png
8 kB
12/Aug/21 7:13 PM
before_patch.png
8 kB
12/Aug/21 7:12 PM
MDL-72242_integration test.png
48 kB
12/Aug/21 5:27 PM
MDL-72242_v3.10 test.png
50 kB
12/Aug/21 5:27 PM
MDL-72242_v3.11 test.png
49 kB
12/Aug/21 5:27 PM

Issue Links

has a non-specific relationship to

MDLSITE-6552 SVG images in moodle.org forum posts have broken

Resolved

is a regression caused by

MDL-55243 SVG files are images and should be allowed for course images, drag-drop questions, etc.

Closed

Testing discovered

MDL-72336 Review filter_censor behaviors and cover it with unit tests

Open

will help resolve

MDL-72294 Some H5P icons are broken in content bank drop down

Closed

Activity

People

Assignee:: David Mudrák (@mudrd8mz)

Reporter:: Matt Porritt

Peer reviewer:: Tim Hunt

Integrator:: Eloy Lafuente (stronk7)

Tester:: Angelia Dela Cruz

Participants:: Angelia Dela Cruz, CiBoT, David Mudrák (@mudrd8mz), Eloy Lafuente (stronk7), Helen Foster, Matt Porritt, Tim Hunt

Votes:: 5 Vote for this issue

Watchers:: 13 Start watching this issue

Dates

Created:: 23/Jul/21 9:56 AM

Updated:: 30/Aug/21 6:57 PM

Resolved:: 12/Aug/21 11:23 PM

Fix Release Date:: 13/Sep/21

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

4h 11m