Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-72286

Atto plugin steals default submit action so enter key in other fields no longer submits the form

    XMLWordPrintable

    Details

      Description

      In Atto, button groups are using a button without a type attribute. They should delcare the type button.

      When focused on an input element, hitting the Enter key should trigger the form's submit button, or the closest button of type submit. However, when a button not declaring its type is found before a submit one, it will be given precedence.

       Replication steps

      • Create a new Page activity, and save.
      • Go back to the Page setting, and focus the "Name" field
      • Hit the "Enter" key

      Expected

      • The form is submitted

      Actual

      • Atto's "Title" plugin is given the focus and its dropdown opens

      (Tested in laster master with Firefox)

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              fred Frédéric Massart
              Reporter:
              fred Frédéric Massart
              Peer reviewer:
              Shamim Rezaie Shamim Rezaie
              Integrator:
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Tester:
              Gladys Basiana Gladys Basiana
              Participants:
              Component watchers:
              Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Huong Nguyen, Barbara Ramiro, Bas Brands, Mathew May
              Votes:
              1 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                13/Sep/21

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 10 minutes
                  1h 10m