Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-72312

PHP 7.2 tests failing in 3.10 & 3.9, caused by buggy php-igbinary extension

    XMLWordPrintable

Details

    • MOODLE_310_STABLE, MOODLE_311_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE
    • MOODLE_310_STABLE, MOODLE_311_STABLE, MOODLE_39_STABLE
    • MDL-72312_310
    • MDL-72312_311
      1. Update to PHP 7.3.x (or later) [OR]
      2. Update to php-igbinary 3.2.5 (or later).
    • Hide
      1. Verify that all the Travis / GHA runs for the branches are passing.
      2. Verify that ToBiC runs are passing.
      3. Optionally (note that these tests have already been performed, both locally and against GHA), if you've easy access to install different php-igbinary versions:
        1. In a PHP 7.2.x environment.
        2. With a buggy extension (>= 3.2.2 and <= 3.2.4).
        3. Install a Moodle 3.9.x or 3.10.x site (from integration.git) via web.
        4. Once arrived to the environmental checks:
          1. Verify that a warning about the problematic extension is shown.
          2. Verify that it links to a page in the docs where the problem is explained.
        5. Then switch to a safe extension (< 3.2.2 or > 3.2.4).
        6. Install a Moodle 3.9.x or 3.10.x site (from integration.git) via web.
        7. Once arrived to the environmental checks:
          1. Verify that there isn't any warning about the problematic extension.
      4. Verify that admin/environment.xml is exactly the same in all branches (aka, the commands below do not return any difference):
        1. git diff MOODLE_39_STABLE master admin/environment.xml
        2. git diff MOODLE_310_STABLE master admin/environment.xml
        3. git diff MOODLE_311_STABLE master admin/environment.xml
      Show
      Verify that all the Travis / GHA runs for the branches are passing. Verify that ToBiC runs are passing. Optionally (note that these tests have already been performed, both locally and against GHA ), if you've easy access to install different php-igbinary versions: In a PHP 7.2.x environment. With a buggy extension (>= 3.2.2 and <= 3.2.4). Install a Moodle 3.9.x or 3.10.x site (from integration.git) via web. Once arrived to the environmental checks: Verify that a warning about the problematic extension is shown. Verify that it links to a page in the docs where the problem is explained. Then switch to a safe extension (< 3.2.2 or > 3.2.4). Install a Moodle 3.9.x or 3.10.x site (from integration.git) via web. Once arrived to the environmental checks: Verify that there isn't any warning about the problematic extension. Verify that admin/environment.xml is exactly the same in all branches (aka, the commands below do not return any difference): git diff MOODLE_39_STABLE master admin/environment.xml git diff MOODLE_310_STABLE master admin/environment.xml git diff MOODLE_311_STABLE master admin/environment.xml

    Description

      Noticed on all the following recent runs that fail consistently on 310 branch only:

      1. https://github.com/paulholden/moodle/runs/3278921433?check_suite_focus=true
      2. https://github.com/paulholden/moodle/runs/3289026931?check_suite_focus=true
      3. https://github.com/paulholden/moodle/runs/3288970240?check_suite_focus=true

      Seems to be when running under mysqli

      There were 33 errors:
       
      1) core_question_events_testcase::test_question_updated
      Undefined index: 
       
      /home/runner/work/moodle/moodle/tag/classes/area.php:164
      /home/runner/work/moodle/moodle/question/type/edit_question_form.php:345
      /home/runner/work/moodle/moodle/question/type/edit_question_form.php:208
      /home/runner/work/moodle/moodle/lib/formslib.php:214
      /home/runner/work/moodle/moodle/question/type/edit_question_form.php:113
      /home/runner/work/moodle/moodle/question/type/questiontypebase.php:217
      /home/runner/work/moodle/moodle/question/engine/tests/helpers.php:132
      /home/runner/work/moodle/moodle/question/tests/events_test.php:379
      /home/runner/work/moodle/moodle/lib/phpunit/classes/advanced_testcase.php:80
       
      2) core_tag_privacy_testcase::test_export_tags
      Undefined index: 
       
      /home/runner/work/moodle/moodle/tag/classes/area.php:164
      /home/runner/work/moodle/moodle/tag/classes/tag.php:771
      /home/runner/work/moodle/moodle/tag/tests/privacy_test.php:64
      /home/runner/work/moodle/moodle/lib/phpunit/classes/advanced_testcase.php:80
       
      3) core_tag_privacy_testcase::test_delete_item_tags
      Undefined index: 
       
      /home/runner/work/moodle/moodle/tag/classes/area.php:164
      /home/runner/work/moodle/moodle/tag/classes/tag.php:771
      /home/runner/work/moodle/moodle/tag/tests/privacy_test.php:106
      /home/runner/work/moodle/moodle/lib/phpunit/classes/advanced_testcase.php:80
       
      4) core_tag_privacy_testcase::test_delete_item_tags_with_userid
      Undefined index: 
       
      /home/runner/work/moodle/moodle/tag/classes/area.php:164
      /home/runner/work/moodle/moodle/tag/classes/tag.php:771
      /home/runner/work/moodle/moodle/tag/tests/privacy_test.php:141
      /home/runner/work/moodle/moodle/lib/phpunit/classes/advanced_testcase.php:80
       
      5) core_tag_privacy_testcase::test_delete_item_tags_select
      Undefined index: 
       
      /home/runner/work/moodle/moodle/tag/classes/area.php:164
      /home/runner/work/moodle/moodle/tag/classes/tag.php:771
      /home/runner/work/moodle/moodle/tag/tests/privacy_test.php:169
      /home/runner/work/moodle/moodle/lib/phpunit/classes/advanced_testcase.php:80
       
      6) mod_quiz_locallib_testcase::test_quiz_retrieve_slot_tags_with_removed_tag
      Undefined index: 
       
      /home/runner/work/moodle/moodle/tag/classes/area.php:164
      /home/runner/work/moodle/moodle/mod/quiz/locallib.php:2563
      /home/runner/work/moodle/moodle/mod/quiz/locallib.php:2587
      /home/runner/work/moodle/moodle/mod/quiz/locallib.php:2599
      /home/runner/work/moodle/moodle/mod/quiz/tests/locallib_test.php:546
      /home/runner/work/moodle/moodle/lib/phpunit/classes/advanced_testcase.php:80
       
      7) mod_quiz_locallib_testcase::test_quiz_retrieve_tags_for_slot_ids_combinations with data set "load from name 1" (2, 2, array(array('foo'), array()), array('unused1', 'unused2'), array(3), array(array(), array(), array('foo'), array()))
      Undefined index: 
       
      /home/runner/work/moodle/moodle/tag/classes/area.php:164
      /home/runner/work/moodle/moodle/mod/quiz/locallib.php:2563
      /home/runner/work/moodle/moodle/mod/quiz/locallib.php:2587
      /home/runner/work/moodle/moodle/mod/quiz/tests/locallib_test.php:819
      /home/runner/work/moodle/moodle/lib/phpunit/classes/advanced_testcase.php:80
       
      8) mod_quiz_locallib_testcase::test_quiz_retrieve_tags_for_slot_ids_combinations with data set "load from name 2" (2, 2, array(array('foo', 'bop'), array('bar')), array('unused1', 'unused2'), array(3), array(array(), array(), array('foo', 'bop'), array('bar')))
      Undefined index: 
       
      /home/runner/work/moodle/moodle/tag/classes/area.php:164
      /home/runner/work/moodle/moodle/mod/quiz/locallib.php:2563
      /home/runner/work/moodle/moodle/mod/quiz/locallib.php:2587
      /home/runner/work/moodle/moodle/mod/quiz/tests/locallib_test.php:819
      /home/runner/work/moodle/moodle/lib/phpunit/classes/advanced_testcase.php:80
       
      9) mod_quiz_locallib_testcase::test_quiz_retrieve_tags_for_slot_ids_combinations with data set "load from name 3" (2, 2, array(array('foo', 'bop'), array('bar', 'foo')), array('unused1', 'unused2'), array(3), array(array(), array(), array('foo', 'bop'), array('bar', 'foo')))
      Undefined index: 
       
      /home/runner/work/moodle/moodle/tag/classes/area.php:164
      /home/runner/work/moodle/moodle/mod/quiz/locallib.php:2563
      /home/runner/work/moodle/moodle/mod/quiz/locallib.php:2587
      /home/runner/work/moodle/moodle/mod/quiz/tests/locallib_test.php:819
      /home/runner/work/moodle/moodle/lib/phpunit/classes/advanced_testcase.php:80
       
      10) mod_quiz_structure_testcase::test_get_slot_tags_for_slot with data set "incorrect slot id" (array(array('TF1', 1, 'truefalse'), array('TF2', 1, 'truefalse'), array('TF3', 1, 'truefalse')), array(array('foo'), array('bar'), array('baz')), null, array())
      Undefined index: 
       
      /home/runner/work/moodle/moodle/tag/classes/area.php:164
      /home/runner/work/moodle/moodle/mod/quiz/tests/structure_test.php:1007
      /home/runner/work/moodle/moodle/lib/phpunit/classes/advanced_testcase.php:80
       
      11) mod_quiz_structure_testcase::test_get_slot_tags_for_slot with data set "no tags" (array(array('TF1', 1, 'truefalse'), array('TF2', 1, 'truefalse'), array('TF3', 1, 'truefalse')), array(array('foo'), array(), array('baz')), 2, array())
      Undefined index: 
       
      /home/runner/work/moodle/moodle/tag/classes/area.php:164
      /home/runner/work/moodle/moodle/mod/quiz/tests/structure_test.php:1007
      /home/runner/work/moodle/moodle/lib/phpunit/classes/advanced_testcase.php:80
       
      12) mod_quiz_structure_testcase::test_get_slot_tags_for_slot with data set "one tag 1" (array(array('TF1', 1, 'truefalse'), array('TF2', 1, 'truefalse'), array('TF3', 1, 'truefalse')), array(array('foo'), array('bar'), array('baz')), 1, array('foo'))
      Undefined index: 
       
      /home/runner/work/moodle/moodle/tag/classes/area.php:164
      /home/runner/work/moodle/moodle/mod/quiz/tests/structure_test.php:1007
      /home/runner/work/moodle/moodle/lib/phpunit/classes/advanced_testcase.php:80
       
      13) mod_quiz_structure_testcase::test_get_slot_tags_for_slot with data set "one tag 2" (array(array('TF1', 1, 'truefalse'), array('TF2', 1, 'truefalse'), array('TF3', 1, 'truefalse')), array(array('foo'), array('bar'), array('baz')), 2, array('bar'))
      Undefined index: 
       
      /home/runner/work/moodle/moodle/tag/classes/area.php:164
      /home/runner/work/moodle/moodle/mod/quiz/tests/structure_test.php:1007
      /home/runner/work/moodle/moodle/lib/phpunit/classes/advanced_testcase.php:80
       
      14) mod_quiz_structure_testcase::test_get_slot_tags_for_slot with data set "multiple tags 1" (array(array('TF1', 1, 'truefalse'), array('TF2', 1, 'truefalse'), array('TF3', 1, 'truefalse')), array(array('foo', 'bar'), array('bar'), array('baz')), 1, array('foo', 'bar'))
      Undefined index: 
       
      /home/runner/work/moodle/moodle/tag/classes/area.php:164
      /home/runner/work/moodle/moodle/mod/quiz/tests/structure_test.php:1007
      /home/runner/work/moodle/moodle/lib/phpunit/classes/advanced_testcase.php:80
       
      15) mod_quiz_structure_testcase::test_get_slot_tags_for_slot with data set "multiple tags 2" (array(array('TF1', 1, 'truefalse'), array('TF2', 1, 'truefalse'), array('TF3', 1, 'truefalse')), array(array('foo', 'bar'), array('bar', 'baz'), array('baz')), 2, array('bar', 'baz'))
      Undefined index: 
       
      /home/runner/work/moodle/moodle/tag/classes/area.php:164
      /home/runner/work/moodle/moodle/mod/quiz/tests/structure_test.php:1007
      /home/runner/work/moodle/moodle/lib/phpunit/classes/advanced_testcase.php:80
       
      16) qtype_calculatedsimple_test::test_question_saving_sumwithvariants
      Undefined index: 
       
      /home/runner/work/moodle/moodle/tag/classes/area.php:164
      /home/runner/work/moodle/moodle/question/type/edit_question_form.php:345
      /home/runner/work/moodle/moodle/question/type/edit_question_form.php:208
      /home/runner/work/moodle/moodle/lib/formslib.php:214
      /home/runner/work/moodle/moodle/question/type/edit_question_form.php:113
      /home/runner/work/moodle/moodle/question/type/calculated/edit_calculated_form.php:65
      /home/runner/work/moodle/moodle/question/type/calculatedsimple/edit_calculatedsimple_form.php:282
      /home/runner/work/moodle/moodle/question/type/questiontypebase.php:217
      /home/runner/work/moodle/moodle/question/engine/tests/helpers.php:132
      /home/runner/work/moodle/moodle/question/type/calculatedsimple/tests/questiontype_test.php:81
      /home/runner/work/moodle/moodle/lib/phpunit/classes/advanced_testcase.php:80
       
      17) qtype_ddimageortext_edit_form_test::test_item_validation
      Undefined index: 
       
      /home/runner/work/moodle/moodle/tag/classes/area.php:164
      /home/runner/work/moodle/moodle/question/type/edit_question_form.php:345
      /home/runner/work/moodle/moodle/question/type/edit_question_form.php:208
      /home/runner/work/moodle/moodle/lib/formslib.php:214
      /home/runner/work/moodle/moodle/question/type/edit_question_form.php:113
      /home/runner/work/moodle/moodle/question/type/ddimageortext/tests/edit_form_test.php:66
      /home/runner/work/moodle/moodle/question/type/ddimageortext/tests/edit_form_test.php:75
      /home/runner/work/moodle/moodle/lib/phpunit/classes/advanced_testcase.php:80
       
      18) qtype_ddmarker_edit_form_test::test_item_validation
      Undefined index: 
       
      /home/runner/work/moodle/moodle/tag/classes/area.php:164
      /home/runner/work/moodle/moodle/question/type/edit_question_form.php:345
      /home/runner/work/moodle/moodle/question/type/edit_question_form.php:208
      /home/runner/work/moodle/moodle/lib/formslib.php:214
      /home/runner/work/moodle/moodle/question/type/edit_question_form.php:113
      /home/runner/work/moodle/moodle/question/type/ddmarker/tests/edit_form_test.php:66
      /home/runner/work/moodle/moodle/question/type/ddmarker/tests/edit_form_test.php:75
      /home/runner/work/moodle/moodle/lib/phpunit/classes/advanced_testcase.php:80
       
      19) qtype_ddwtos_edit_form_test::test_number_of_choice_groups
      Undefined index: 
       
      /home/runner/work/moodle/moodle/tag/classes/area.php:164
      /home/runner/work/moodle/moodle/question/type/edit_question_form.php:345
      /home/runner/work/moodle/moodle/question/type/edit_question_form.php:208
      /home/runner/work/moodle/moodle/lib/formslib.php:214
      /home/runner/work/moodle/moodle/question/type/edit_question_form.php:113
      /home/runner/work/moodle/moodle/question/type/ddwtos/tests/edit_form_test.php:68
      /home/runner/work/moodle/moodle/question/type/ddwtos/tests/edit_form_test.php:77
      /home/runner/work/moodle/moodle/lib/phpunit/classes/advanced_testcase.php:80
       
      20) qtype_ddwtos_edit_form_test::test_choices_validation
      Undefined index: 
       
      /home/runner/work/moodle/moodle/tag/classes/area.php:164
      /home/runner/work/moodle/moodle/question/type/edit_question_form.php:345
      /home/runner/work/moodle/moodle/question/type/edit_question_form.php:208
      /home/runner/work/moodle/moodle/lib/formslib.php:214
      /home/runner/work/moodle/moodle/question/type/edit_question_form.php:113
      /home/runner/work/moodle/moodle/question/type/ddwtos/tests/edit_form_test.php:68
      /home/runner/work/moodle/moodle/question/type/ddwtos/tests/edit_form_test.php:91
      /home/runner/work/moodle/moodle/lib/phpunit/classes/advanced_testcase.php:80
       
      21) qtype_description_test::test_question_saving
      Undefined index: 
       
      /home/runner/work/moodle/moodle/tag/classes/area.php:164
      /home/runner/work/moodle/moodle/question/type/edit_question_form.php:345
      /home/runner/work/moodle/moodle/question/type/edit_question_form.php:208
      /home/runner/work/moodle/moodle/lib/formslib.php:214
      /home/runner/work/moodle/moodle/question/type/edit_question_form.php:113
      /home/runner/work/moodle/moodle/question/type/questiontypebase.php:217
      /home/runner/work/moodle/moodle/question/engine/tests/helpers.php:132
      /home/runner/work/moodle/moodle/question/type/description/tests/questiontype_test.php:86
      /home/runner/work/moodle/moodle/lib/phpunit/classes/advanced_testcase.php:80
       
      22) qtype_gapselect_edit_form_test::test_get_illegal_tag_error
      Undefined index: 
       
      /home/runner/work/moodle/moodle/tag/classes/area.php:164
      /home/runner/work/moodle/moodle/question/type/edit_question_form.php:345
      /home/runner/work/moodle/moodle/question/type/edit_question_form.php:208
      /home/runner/work/moodle/moodle/lib/formslib.php:214
      /home/runner/work/moodle/moodle/question/type/edit_question_form.php:113
      /home/runner/work/moodle/moodle/question/type/gapselect/tests/edit_form_test.php:93
      /home/runner/work/moodle/moodle/question/type/gapselect/tests/edit_form_test.php:99
      /home/runner/work/moodle/moodle/lib/phpunit/classes/advanced_testcase.php:80
       
      23) qtype_gapselect_edit_form_test::test_number_of_choice_groups
      Undefined index: 
       
      /home/runner/work/moodle/moodle/tag/classes/area.php:164
      /home/runner/work/moodle/moodle/question/type/edit_question_form.php:345
      /home/runner/work/moodle/moodle/question/type/edit_question_form.php:208
      /home/runner/work/moodle/moodle/lib/formslib.php:214
      /home/runner/work/moodle/moodle/question/type/edit_question_form.php:113
      /home/runner/work/moodle/moodle/question/type/gapselect/tests/edit_form_test.php:93
      /home/runner/work/moodle/moodle/question/type/gapselect/tests/edit_form_test.php:140
      /home/runner/work/moodle/moodle/lib/phpunit/classes/advanced_testcase.php:80
       
      24) qtype_gapselect_edit_form_test::test_choices_validation
      Undefined index: 
       
      /home/runner/work/moodle/moodle/tag/classes/area.php:164
      /home/runner/work/moodle/moodle/question/type/edit_question_form.php:345
      /home/runner/work/moodle/moodle/question/type/edit_question_form.php:208
      /home/runner/work/moodle/moodle/lib/formslib.php:214
      /home/runner/work/moodle/moodle/question/type/edit_question_form.php:113
      /home/runner/work/moodle/moodle/question/type/gapselect/tests/edit_form_test.php:93
      /home/runner/work/moodle/moodle/question/type/gapselect/tests/edit_form_test.php:154
      /home/runner/work/moodle/moodle/lib/phpunit/classes/advanced_testcase.php:80
       
      25) qtype_match_test::test_question_saving_foursubq
      Undefined index: 
       
      /home/runner/work/moodle/moodle/tag/classes/area.php:164
      /home/runner/work/moodle/moodle/question/type/edit_question_form.php:345
      /home/runner/work/moodle/moodle/question/type/edit_question_form.php:208
      /home/runner/work/moodle/moodle/lib/formslib.php:214
      /home/runner/work/moodle/moodle/question/type/edit_question_form.php:113
      /home/runner/work/moodle/moodle/question/type/questiontypebase.php:217
      /home/runner/work/moodle/moodle/question/engine/tests/helpers.php:132
      /home/runner/work/moodle/moodle/question/type/match/tests/questiontype_test.php:177
      /home/runner/work/moodle/moodle/lib/phpunit/classes/advanced_testcase.php:80
       
      26) qtype_multianswer_test::test_question_saving_twosubq
      Undefined index: 
       
      /home/runner/work/moodle/moodle/tag/classes/area.php:164
      /home/runner/work/moodle/moodle/question/type/edit_question_form.php:345
      /home/runner/work/moodle/moodle/question/type/edit_question_form.php:208
      /home/runner/work/moodle/moodle/lib/formslib.php:214
      /home/runner/work/moodle/moodle/question/type/edit_question_form.php:113
      /home/runner/work/moodle/moodle/question/type/multianswer/edit_multianswer_form.php:83
      /home/runner/work/moodle/moodle/question/type/questiontypebase.php:217
      /home/runner/work/moodle/moodle/question/engine/tests/helpers.php:132
      /home/runner/work/moodle/moodle/question/type/multianswer/tests/questiontype_test.php:242
      /home/runner/work/moodle/moodle/lib/phpunit/classes/advanced_testcase.php:80
       
      27) qtype_multichoice_test::test_question_saving_two_of_four with data set #0 ('two_of_four')
      Undefined index: 
       
      /home/runner/work/moodle/moodle/tag/classes/area.php:164
      /home/runner/work/moodle/moodle/question/type/edit_question_form.php:345
      /home/runner/work/moodle/moodle/question/type/edit_question_form.php:208
      /home/runner/work/moodle/moodle/lib/formslib.php:214
      /home/runner/work/moodle/moodle/question/type/edit_question_form.php:113
      /home/runner/work/moodle/moodle/question/type/questiontypebase.php:217
      /home/runner/work/moodle/moodle/question/engine/tests/helpers.php:132
      /home/runner/work/moodle/moodle/question/type/multichoice/tests/questiontype_test.php:125
      /home/runner/work/moodle/moodle/lib/phpunit/classes/advanced_testcase.php:80
       
      28) qtype_multichoice_test::test_question_saving_two_of_four with data set #1 ('one_of_four')
      Undefined index: 
       
      /home/runner/work/moodle/moodle/tag/classes/area.php:164
      /home/runner/work/moodle/moodle/question/type/edit_question_form.php:345
      /home/runner/work/moodle/moodle/question/type/edit_question_form.php:208
      /home/runner/work/moodle/moodle/lib/formslib.php:214
      /home/runner/work/moodle/moodle/question/type/edit_question_form.php:113
      /home/runner/work/moodle/moodle/question/type/questiontypebase.php:217
      /home/runner/work/moodle/moodle/question/engine/tests/helpers.php:132
      /home/runner/work/moodle/moodle/question/type/multichoice/tests/questiontype_test.php:125
      /home/runner/work/moodle/moodle/lib/phpunit/classes/advanced_testcase.php:80
       
      29) qtype_multichoice_test::test_get_question_options
      Undefined index: 
       
      /home/runner/work/moodle/moodle/tag/classes/area.php:164
      /home/runner/work/moodle/moodle/question/type/edit_question_form.php:345
      /home/runner/work/moodle/moodle/question/type/edit_question_form.php:208
      /home/runner/work/moodle/moodle/lib/formslib.php:214
      /home/runner/work/moodle/moodle/question/type/edit_question_form.php:113
      /home/runner/work/moodle/moodle/question/type/questiontypebase.php:217
      /home/runner/work/moodle/moodle/question/engine/tests/helpers.php:132
      /home/runner/work/moodle/moodle/question/type/multichoice/tests/questiontype_test.php:186
      /home/runner/work/moodle/moodle/lib/phpunit/classes/advanced_testcase.php:80
       
      30) qtype_numerical_test::test_question_saving_pi
      Undefined index: 
       
      /home/runner/work/moodle/moodle/tag/classes/area.php:164
      /home/runner/work/moodle/moodle/question/type/edit_question_form.php:345
      /home/runner/work/moodle/moodle/question/type/edit_question_form.php:208
      /home/runner/work/moodle/moodle/lib/formslib.php:214
      /home/runner/work/moodle/moodle/question/type/edit_question_form.php:113
      /home/runner/work/moodle/moodle/question/type/questiontypebase.php:217
      /home/runner/work/moodle/moodle/question/engine/tests/helpers.php:132
      /home/runner/work/moodle/moodle/question/type/numerical/tests/questiontype_test.php:140
      /home/runner/work/moodle/moodle/lib/phpunit/classes/advanced_testcase.php:80
       
      31) qtype_shortanswer_test::test_question_saving_frogtoad
      Undefined index: 
       
      /home/runner/work/moodle/moodle/tag/classes/area.php:164
      /home/runner/work/moodle/moodle/question/type/edit_question_form.php:345
      /home/runner/work/moodle/moodle/question/type/edit_question_form.php:208
      /home/runner/work/moodle/moodle/lib/formslib.php:214
      /home/runner/work/moodle/moodle/question/type/edit_question_form.php:113
      /home/runner/work/moodle/moodle/question/type/questiontypebase.php:217
      /home/runner/work/moodle/moodle/question/engine/tests/helpers.php:132
      /home/runner/work/moodle/moodle/question/type/shortanswer/tests/questiontype_test.php:112
      /home/runner/work/moodle/moodle/lib/phpunit/classes/advanced_testcase.php:80
       
      32) qtype_shortanswer_test::test_question_saving_trims_answers
      Undefined index: 
       
      /home/runner/work/moodle/moodle/tag/classes/area.php:164
      /home/runner/work/moodle/moodle/question/type/edit_question_form.php:345
      /home/runner/work/moodle/moodle/question/type/edit_question_form.php:208
      /home/runner/work/moodle/moodle/lib/formslib.php:214
      /home/runner/work/moodle/moodle/question/type/edit_question_form.php:113
      /home/runner/work/moodle/moodle/question/type/questiontypebase.php:217
      /home/runner/work/moodle/moodle/question/engine/tests/helpers.php:132
      /home/runner/work/moodle/moodle/question/type/shortanswer/tests/questiontype_test.php:159
      /home/runner/work/moodle/moodle/lib/phpunit/classes/advanced_testcase.php:80
       
      33) qtype_truefalse_test::test_question_saving_true
      Undefined index: 
       
      /home/runner/work/moodle/moodle/tag/classes/area.php:164
      /home/runner/work/moodle/moodle/question/type/edit_question_form.php:345
      /home/runner/work/moodle/moodle/question/type/edit_question_form.php:208
      /home/runner/work/moodle/moodle/lib/formslib.php:214
      /home/runner/work/moodle/moodle/question/type/edit_question_form.php:113
      /home/runner/work/moodle/moodle/question/type/questiontypebase.php:217
      /home/runner/work/moodle/moodle/question/engine/tests/helpers.php:132
      /home/runner/work/moodle/moodle/question/type/truefalse/tests/questiontype_test.php:152
      /home/runner/work/moodle/moodle/lib/phpunit/classes/advanced_testcase.php:80
      

      Haven't seen similar failures in master/311 branches

      Attachments

        Issue Links

          Activity

            People

              stronk7 Eloy Lafuente (stronk7)
              pholden Paul Holden
              Tim Hunt Tim Hunt
              Andrew Lyons Andrew Lyons
              Sujith Haridasan Sujith Haridasan
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan, Matteo Scaramuccia, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona), Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              2 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                13/Sep/21

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 7 hours, 10 minutes
                  7h 10m