Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-72324

plugin incompatible check is backwards in upgradelib

    XMLWordPrintable

Details

    • Bug
    • Status: Development in progress
    • Minor
    • Resolution: Unresolved
    • 4.0
    • None
    • Administration

    Description

      https://github.com/moodle/moodle/blob/master/lib/upgradelib.php#L628

      The check here is backwards, and is opposite to both the docs and the UI check here:

      https://github.com/moodle/moodle/blob/master/lib/classes/plugininfo/base.php#L378

      Upgradelib just needs a flip from <= to >=

       

      This snuck through in MDL-59562 as the testing instruction for this was checking the equals condition, which passes for both >= and <=

      Attachments

        Activity

          People

            peterburnett Peter Burnett
            peterburnett Peter Burnett
            Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated: