Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-72324

plugin incompatible check is backwards in upgradelib

    XMLWordPrintable

Details

    • MOODLE_311_STABLE, MOODLE_400_STABLE
    • MOODLE_311_STABLE, MOODLE_400_STABLE
    • MDL-72324-incompatible-check-311
    • MDL-72324-incompatible-check-400
    • MDL-72324-incompatible-check
    • Hide

      Prerequisites: Clone the same version tester used in MDL-59562

      git clone git@github.com:Peterburnett/mdl-59562-tester.git admin/tool/versiontester

      1) Start an upgrade from the web, and confirm on the 'Plugins check' step that you see the error 'Incompatible Moodle version: 401'

      2) Run a CLI upgrade:

      php admin/cli/upgrade.php

      3) Verify that you see a message about failed dependency check:

      Dependencies check failed for tool_versiontester
      		 
      You must solve all the plugin requirements before proceeding to install this Moodle version!

      4) Edit admin/tool/versiontester/version.php and change the incompatible declaration to `$plugin->incompatible = 410;`

      5) Run a CLI upgrade again:

       php admin/cli/upgrade.php

      6) Verify that the upgrade continues and prompts for confirmation.

       

      Show
      Prerequisites: Clone the same version tester used in MDL-59562 git clone git @github .com:Peterburnett/mdl- 59562 -tester.git admin/tool/versiontester 1) Start an upgrade from the web, and confirm on the 'Plugins check' step that you see the error 'Incompatible Moodle version: 401' 2) Run a CLI upgrade: php admin/cli/upgrade.php 3) Verify that you see a message about failed dependency check: Dependencies check failed for tool_versiontester You must solve all the plugin requirements before proceeding to install this Moodle version! 4) Edit admin/tool/versiontester/version.php and change the incompatible declaration to `$plugin->incompatible = 410;` 5) Run a CLI upgrade again: php admin/cli/upgrade.php 6) Verify that the upgrade continues and prompts for confirmation.  

    Description

      https://github.com/moodle/moodle/blob/master/lib/upgradelib.php#L628

      The check here is backwards, and is opposite to both the docs and the UI check here:

      https://github.com/moodle/moodle/blob/master/lib/classes/plugininfo/base.php#L378

      Upgradelib just needs a flip from <= to >=

       

      This snuck through in MDL-59562 as the testing instruction for this was checking the equals condition, which passes for both >= and <=

      Attachments

        1. MDL-72324_master_1.png
          96 kB
          Angelia Dela Cruz
        2. MDL-72324_master_2.png
          96 kB
          Angelia Dela Cruz
        3. MDL-72324_v311_1.png
          100 kB
          Angelia Dela Cruz
        4. MDL-72324_v311_2.png
          88 kB
          Angelia Dela Cruz
        5. MDL-72324_v400_1.png
          97 kB
          Angelia Dela Cruz
        6. MDL-72324_v400_2.png
          83 kB
          Angelia Dela Cruz

        Issue Links

          has a non-specific relationship to

          Improvement - An enhancement to an existing Moodle feature. MDL-59562 Allow plugins to declare which major stable versions of moodle are supported

          • Major - Major loss of function, incorrect output
          • Closed
          has been marked as being related by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-77128 Backport MDL-72324 to Moodle 3.9

          • Minor - Minor loss of function where workaround is possible
          • Closed
          Testing discovered

          Improvement - An enhancement to an existing Moodle feature. MDL-74928 Detect inconsistent supported and incompatible in version.php

          • Minor - Minor loss of function where workaround is possible
          • Open

          Activity

            People

              peterburnett Peter Burnett
              peterburnett Peter Burnett
              Brendan Heywood Brendan Heywood
              Jun Pataleta Jun Pataleta
              Angelia Dela Cruz Angelia Dela Cruz
              David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo
              Votes:
              2 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                11/Jul/22

                Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 15 minutes
                  15m