Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-72348

Remove Microsoft OneDrive (legacy) repository (repository_skydrive) from core

    XMLWordPrintable

    Details

    • Affected Branches:
      MOODLE_400_STABLE
    • Fixed Branches:
      MOODLE_400_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-72348-master
    • Testing Instructions:
      Hide

      Setup

      1. Debugging should be enabled and set to "DEVELOPER".

      Testing instructions: Skydrive uninstalled

      1. Login as admin.
      2. Go to "Site administration > Plugins > Plugins overview".
      3. Verify there is no longer a mention of 'Microsoft OneDrive (legacy)'.
      4. Access to "Site administration > Server > OAuth 2 services".
      5. Create a "Microsoft" OAuth2 service. You can use "aaa" and "aaa" as ClientID and Client secret.
      6. Access to "Site administration > Plugins > Manage repositories".
      7. Enable the "Microsoft OneDrive" repository. Select the OAuth2 service created previously.
      8. Access to the "Settings" page of the Microsoft OneDrive repository.
      9. Check no debugging message is displayed.
      10. Check the button "Import files from Microsoft SkyDrive repository" is not displayed.

      Testing instructions: Skydrive re-installed

      1. Re-install the repository_skydrive (you will find the .zip file with the plugin attached to this issue).
      2. Access to "Site administration > Plugins > Manage repositories".
      3. Access to the "Settings" page of the Microsoft OneDrive repository.
      4. Check no debugging message is displayed.
      5. Check the button "Import files from Microsoft SkyDrive repository" is not displayed.
      6. Enable the "Microsoft Skydrive" repository. You can write down any dummy values for "Client ID" and "Secret" (they don't have to be valid).
      7. Access to the "Settings" page of the Microsoft OneDrive repository.
      8. Check a debugging message is displayed: "can_import_skydrive_files() is deprecated. Please migrate your files from repository_skydrive to repository_onedrive before it will be completely removed.".
      9. Check the button "Import files from Microsoft SkyDrive repository" is displayed.

       

      Show
      Setup Debugging should be enabled and set to "DEVELOPER". Testing instructions: Skydrive uninstalled Login as admin. Go to "Site administration > Plugins > Plugins overview". Verify  there is no longer a mention of 'Microsoft OneDrive (legacy)'. Access to "Site administration > Server > OAuth 2 services". Create a "Microsoft" OAuth2 service. You can use "aaa" and "aaa" as ClientID and Client secret. Access to "Site administration > Plugins > Manage repositories". Enable the "Microsoft OneDrive" repository. Select the OAuth2 service created previously. Access to the "Settings" page of the Microsoft OneDrive repository. Check no debugging message is displayed. Check the button "Import files from Microsoft SkyDrive repository" is not displayed. Testing instructions: Skydrive re-installed Re-install the repository_skydrive (you will find the .zip file with the plugin attached to this issue). Access to "Site administration > Plugins > Manage repositories". Access to the "Settings" page of the Microsoft OneDrive repository. Check no debugging message is displayed. Check the button "Import files from Microsoft SkyDrive repository" is not displayed. Enable the "Microsoft Skydrive" repository. You can write down any dummy values for "Client ID" and "Secret" (they don't have to be valid). Access to the "Settings" page of the Microsoft OneDrive repository. Check a debugging message is displayed: "can_import_skydrive_files() is deprecated. Please migrate your files from repository_skydrive to repository_onedrive before it will be completely removed.". Check the button "Import files from Microsoft SkyDrive repository" is displayed.  
    • Sprint:
      Moppies Kanban

      Description

      In Moodle 3.3, the skydrive repository was renamed to "Microsoft OneDrive (legacy)" because the API used by this repository plugin was deprecated by Microsoft. Users were encouraged to migrate to the new OneDrive repository right away some years ago (which is using oAuth2) so this repository_skydrive repository can be completely removed from Moodle core.
       

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              sarjona Sara Arjona (@sarjona)
              Reporter:
              sarjona Sara Arjona (@sarjona)
              Peer reviewer:
              Carlos Escobedo Carlos Escobedo
              Integrator:
              Andrew Lyons Andrew Lyons
              Tester:
              Gladys Basiana Gladys Basiana
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 5 hours, 20 minutes
                  5h 20m