Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-72352

Ensure that the secondary navigation is backwards compatible.

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Tested
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: Future Dev
    • Fix Version/s: 4.0
    • Component/s: Navigation
    • Testing Instructions:
      Hide

      Unit test provided.

      Manual testing

      Requirements

      This test requires the ability to install a 3rd party plugin so this requires elevated privileges to modify the moodle install.

      1. Download the questionnaire plugin - https://moodle.org/plugins/view.php?plugin=mod_questionnaire
      2. Install the plugin following the instructions here https://docs.moodle.org/311/en/Installing_plugins#Installing_a_plugin
      3. A course with a student enrolled.
      4. Restore the attached backup into the course. backup-moodle2-activity-4165-questionnaire4165-20210901-1457.mbz

      Testing

      1. Log in as admin
      2. Go to the course with editing on
      3. Go to the restored module
      4. Add the 'Administration block' if it does not exist
      5. Edit the Administration block and adjust the "Where this block appears > Display on page types" setting to "mod-questionnaire-*"
      6. Confirm you see the following additional tabs
        1. Advanced settings
        2. Questions
        3. Feedback
      7. Confirm you see the following additional options in the 'more' menu after the Competency breakdown:
        1. Preview
        2. Answer the questions
        3. View all Responses
        4. Non-respondents
      8. Navigate to 'View all responses' in the More menu
      9. Confirm you see a dropdown in the top left corner of the module page.
      10. Confirm the contents of the dropdown contain the contents of the 'View all responses' in the administration block
      11. Confirm you can navigate to the subpages via the dropdown.
      Show
      Unit test provided. Manual testing Requirements This test requires the ability to install a 3rd party plugin so this requires elevated privileges to modify the moodle install. Download the questionnaire plugin - https://moodle.org/plugins/view.php?plugin=mod_questionnaire Install the plugin following the instructions here https://docs.moodle.org/311/en/Installing_plugins#Installing_a_plugin A course with a student enrolled. Restore the attached backup into the course. backup-moodle2-activity-4165-questionnaire4165-20210901-1457.mbz Testing Log in as admin Go to the course with editing on Go to the restored module Add the 'Administration block' if it does not exist Edit the Administration block and adjust the "Where this block appears > Display on page types" setting to " mod-questionnaire-* " Confirm you see the following additional tabs Advanced settings Questions Feedback Confirm you see the following additional options in the 'more' menu after the Competency breakdown: Preview Answer the questions View all Responses Non-respondents Navigate to 'View all responses' in the More menu Confirm you see a dropdown in the top left corner of the module page. Confirm the contents of the dropdown contain the contents of the 'View all responses' in the administration block Confirm you can navigate to the subpages via the dropdown.
    • Fixed Branches:
      MOODLE_400_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-72352-master-v2
    • Story Points:
      5
    • Sprint:
      Navigation push 4, Navigation push 5, Navigation push 6

      Description

      Third party plugins can insert items into the navigation in two different ways:

      1. By using one of the callbacks to extend the navigation.
      2. By finding the navigation node and directly adding a new navigation node.

      We need to ensure that any navigation that is included in both of these situations is included into the secondary navigation.

      Important: We are not only dealing with single navigation nodes, but also nodes that have children. We must have a solution that allows categories of nodes to be navigated to.

      Until we have a better solution we will allow drop down menu items to be entered into the secondary navigation similar to how the custom menu is added to the primary navigation.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              peterdias Peter Dias
              Reporter:
              abgreeve Adrian Greeve
              Peer reviewer:
              Mihail Geshoski Mihail Geshoski
              Integrator:
              Jun Pataleta Jun Pataleta
              Tester:
              Gladys Basiana Gladys Basiana
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Fix Release Date:
                13/Dec/21

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 week, 5 minutes
                  1w 5m