Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-72355

Update page title and links relating to Manage Subscriptions page

    XMLWordPrintable

    Details

    • Affected Branches:
      MOODLE_400_STABLE
    • Fixed Branches:
      MOODLE_400_STABLE
    • Pull Master Branch:
      MDL-72355-master
    • Testing Instructions:
      Hide

      Pretty well covered by behat, but here's a quick test to confirm all looks as expected:

      1. Log in as any user and navigate to the dashboard.
      2. Add the calendar block if it is not already visible.
      3. CONFIRM below the calendar in the calendar block, you see "Full calendar" and "Import or export calendars" links.
      4. Click the "Import or export calendars" link.
      5. CONFIRM you are taken to a page with URL in the format "<yoursite>/calendar/managesubscriptions.php".
      6. Navigate to a course page, then click on its calendar link in the side navigation.
      7. CONFIRM you are again taken to a page with URL in the format "<yoursite>/calendar/managesubscriptions.php".
      8. CONFIRM in the title of the page, you see "Import or export calendars" and not "Manage subscriptions".
      9. CONFIRM below that heading, you see an "Imported calendars" heading (and not "Your subscriptions").
      10. Right click the "Imported calendars" heading and select "Inspect".
      11. CONFIRM the heading has an "aria-describedby" attribute, which has the value "subscription_details_table".
      12. Click on the "Import calendar" button.
      13. CONFIRM in the page breadcrumbs, you see "Import or export calendars".
      14. In the page breadcrumbs, click on the "Calendar" link.
      15. CONFIRM that below the calendar there is a single link, "Import or export calendars".
      16. CONFIRM that clicking the link returns you to the page you were on in steps 5-9.
      Show
      Pretty well covered by behat, but here's a quick test to confirm all looks as expected: Log in as any user and navigate to the dashboard. Add the calendar block if it is not already visible. CONFIRM below the calendar in the calendar block, you see "Full calendar" and "Import or export calendars" links. Click the "Import or export calendars" link. CONFIRM you are taken to a page with URL in the format "<yoursite>/calendar/managesubscriptions.php". Navigate to a course page, then click on its calendar link in the side navigation. CONFIRM you are again taken to a page with URL in the format "<yoursite>/calendar/managesubscriptions.php". CONFIRM in the title of the page, you see "Import or export calendars" and not "Manage subscriptions". CONFIRM below that heading, you see an "Imported calendars" heading (and not "Your subscriptions"). Right click the "Imported calendars" heading and select "Inspect". CONFIRM the heading has an "aria-describedby" attribute, which has the value "subscription_details_table". Click on the "Import calendar" button. CONFIRM in the page breadcrumbs, you see "Import or export calendars". In the page breadcrumbs, click on the "Calendar" link. CONFIRM that below the calendar there is a single link, "Import or export calendars". CONFIRM that clicking the link returns you to the page you were on in steps 5-9.
    • Story Points:
      0
    • Sprint:
      HQ Team International Sprint 7, HQ Team International Sprint 8, HQ Team International Sprint 9, HQ Team International Sprin 10

      Description

      We have an existing page called "Manage Subscriptions" (<wwwroot>/calendar/managesubscriptions.php), which previously only handled importing (subscribing to) calendars. With the latest calendar project, that is no longer true, as the page now has content relating to both the importing/subscribing to calendars, as well as exporting them.

      It has therefore been decided that the following changes should be made, to avoid link duplication and confusion around the page's purpose:

      1. Update the managesubscriptions calendar language string so its text is replaced with "Import / export calendars".
      2. Remove the "Export calendar" link from below the main calendar (and the dot after it), so that only the link with the new text from #1 is shown.
      3. Update the "Your Subscriptions" heading / language string to be "Imported calendars", and set it as the aria-described by attribute for the table.
      4. Update any behat tests that are affected by the above changes.

      To be safe, the filename (managesubscriptions.php) should remain the same (also for backwards compatibility).

        Attachments

        1. import-export-text.png
          import-export-text.png
          81 kB
        2. MDL-72355_Step 11.png
          MDL-72355_Step 11.png
          231 kB
        3. MDL-72355_Step 13.png
          MDL-72355_Step 13.png
          86 kB
        4. MDL-72355_Step 15.png
          MDL-72355_Step 15.png
          136 kB
        5. MDL-72355_Step 16.png
          MDL-72355_Step 16.png
          148 kB
        6. MDL-72355_Step 3.png
          MDL-72355_Step 3.png
          92 kB
        7. MDL-72355_Step 5, 7.png
          MDL-72355_Step 5, 7.png
          90 kB
        8. MDL-72355_Step 8-9.png
          MDL-72355_Step 8-9.png
          116 kB

          Activity

            People

            Assignee:
            michaelh Michael Hawkins
            Reporter:
            michaelh Michael Hawkins
            Peer reviewer:
            Dongsheng Cai Dongsheng Cai
            Integrator:
            Adrian Greeve Adrian Greeve
            Tester:
            Angelia Dela Cruz Angelia Dela Cruz
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan, Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 day, 1 hour, 32 minutes
                1d 1h 32m