The VideoJS Flash plugin should be removed from core

Setup The following steps should be run on a Moodle site without the patch. For instance, you can run "git checkout 036800d99debfe61dde45f61292bc5ad44ab7cb0". Login as admin. Go to "Site administration > Plugins > Media players > VideoJS player". Enable RTMP streams(rtmp) and Use Flash fallback (useflash) settings. Check  the following SQL query returns a number greater than zero: SELECT count(*) FROM mdl_config_plugins WHERE plugin= 'media_videojs' AND (name= 'useflash' OR name= 'rtmp' ) Create a course. Add page to the course and in the editor insert the URL link pointing to rtmp://184.72.239.149/vod/&mp4:BigBuckBunny_115k.mov (example stream URL is taken from https://www.hdwplayer.com/rtmp-player/) Save and view the page in the browser. Check a player is displayed (it probably won't work and, in some cases, such as Firefox, the following error might appear "No compatible source was found for this media."). Testing instructions Apply the patch and run the upgrade process. Go to "Site administration > Plugins > Media players > Manage media players". Check  "RTMP streams" doesn't appear in the Supports column Go to "Site administration > Plugins > Media players > VideoJS player". Check RTMP streams(rtmp) and Use Flash fallback (useflash) settings don't appear. Check there is no reference to Flash in the description for "Video file extensions" and "Audio file extensions" settings. Go to the course. Check the page now displays a link (instead of the player). Go to "Site administration > Development > Third party libraries". Check "The Flash tech for video.js" and "Custom Flash Player for VideoJS" are NOT displayed. Check  the following SQL query returns zero: SELECT count(*) FROM mdl_config_plugins WHERE plugin= 'media_videojs' AND (name= 'useflash' OR name= 'rtmp' )