Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-72407

The VideoJS Flash plugin should be removed from core

    XMLWordPrintable

    Details

    • Affected Branches:
      MOODLE_311_STABLE
    • Fixed Branches:
      MOODLE_400_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-72407-master
    • Testing Instructions:
      Hide

      Setup

      The following steps should be run on a Moodle site without the patch. For instance, you can run "git checkout 036800d99debfe61dde45f61292bc5ad44ab7cb0".

      1. Login as admin.
      2. Go to "Site administration > Plugins > Media players > VideoJS player".
      3. Enable RTMP streams(rtmp) and Use Flash fallback (useflash) settings.
      4. Check the following SQL query returns a number greater than zero:

        SELECT count(*) FROM mdl_config_plugins WHERE plugin='media_videojs' AND (name='useflash' OR name='rtmp')

      1. Create a course.
      2. Add page to the course and in the editor insert the URL link pointing to rtmp://184.72.239.149/vod/&mp4:BigBuckBunny_115k.mov (example stream URL is taken from https://www.hdwplayer.com/rtmp-player/)
      3. Save and view the page in the browser.
      4. Check a player is displayed (it probably won't work and, in some cases, such as Firefox, the following error might appear "No compatible source was found for this media.").

      Testing instructions

      1. Apply the patch and run the upgrade process.
      2. Go to "Site administration > Plugins > Media players > Manage media players".
      3. Check "RTMP streams" doesn't appear in the Supports column
      4. Go to "Site administration > Plugins > Media players > VideoJS player".
      5. Check RTMP streams(rtmp) and Use Flash fallback (useflash) settings don't appear.
      6. Check there is no reference to Flash in the description for "Video file extensions" and "Audio file extensions" settings.
      7. Go to the course.
      8. Check the page now displays a link (instead of the player).
      9. Go to "Site administration > Development > Third party libraries".
      10. Check "The Flash tech for video.js" and "Custom Flash Player for VideoJS" are NOT displayed.
      11. Check the following SQL query returns zero:

        SELECT count(*) FROM mdl_config_plugins WHERE plugin='media_videojs' AND (name='useflash' OR name='rtmp')

       
       

      Show
      Setup The following steps should be run on a Moodle site without the patch. For instance, you can run "git checkout 036800d99debfe61dde45f61292bc5ad44ab7cb0". Login as admin. Go to "Site administration > Plugins > Media players > VideoJS player". Enable RTMP streams(rtmp) and Use Flash fallback (useflash) settings. Check  the following SQL query returns a number greater than zero: SELECT count(*) FROM mdl_config_plugins WHERE plugin= 'media_videojs' AND (name= 'useflash' OR name= 'rtmp' ) Create a course. Add page to the course and in the editor insert the URL link pointing to rtmp://184.72.239.149/vod/&mp4:BigBuckBunny_115k.mov (example stream URL is taken from https://www.hdwplayer.com/rtmp-player/) Save and view the page in the browser. Check a player is displayed (it probably won't work and, in some cases, such as Firefox, the following error might appear "No compatible source was found for this media."). Testing instructions Apply the patch and run the upgrade process. Go to "Site administration > Plugins > Media players > Manage media players". Check  "RTMP streams" doesn't appear in the Supports column Go to "Site administration > Plugins > Media players > VideoJS player". Check RTMP streams(rtmp) and Use Flash fallback (useflash) settings don't appear. Check there is no reference to Flash in the description for "Video file extensions" and "Audio file extensions" settings. Go to the course. Check the page now displays a link (instead of the player). Go to "Site administration > Development > Third party libraries". Check "The Flash tech for video.js" and "Custom Flash Player for VideoJS" are NOT displayed. Check  the following SQL query returns zero: SELECT count(*) FROM mdl_config_plugins WHERE plugin= 'media_videojs' AND (name= 'useflash' OR name= 'rtmp' )    
    • Sprint:
      Moppies Kanban

      Description

      As mentioned by Ruslan Kabalin in a comment in MDL-58065 we should remove the videojs flash plugin and all related code (loader, etc.) - including the VideoJS player settings RTMP streams (media_videojs | rtmp) and Use Flash fallback (media_videojs | useflash) and the references to Flash fallback in the strings configaudioextensions and configvideoextensions

        Attachments

        1. image.jpg
          image.jpg
          105 kB
        2. test 1 step 4.png
          test 1 step 4.png
          119 kB
        3. test 1 step second 4.png
          test 1 step second 4.png
          191 kB
        4. test 2 step 10.png
          test 2 step 10.png
          968 kB
        5. test 2 step 11.png
          test 2 step 11.png
          119 kB
        6. test 2 step 3.png
          test 2 step 3.png
          102 kB
        7. test 2 step 5 and 6.png
          test 2 step 5 and 6.png
          1.07 MB
        8. test 2 step 8.png
          test 2 step 8.png
          854 kB

          Issue Links

            Activity

              People

              Assignee:
              sarjona Sara Arjona (@sarjona)
              Reporter:
              tsala Helen Foster
              Peer reviewer:
              Carlos Escobedo Carlos Escobedo
              Integrator:
              Andrew Lyons Andrew Lyons
              Tester:
              Bas Brands Bas Brands
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 6 hours, 10 minutes
                  6h 10m