Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.7
    • Fix Version/s: 1.7, 1.8
    • Component/s: RSS
    • Labels:
      None
    • Affected Branches:
      MOODLE_17_STABLE
    • Fixed Branches:
      MOODLE_17_STABLE, MOODLE_18_STABLE

      Description

      RSS feeds in blogs throw warnings in debug mode, in normal mode are empty.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              skodak Petr Skoda added a comment -

              I think Martin fixed it today, seems to work fine, closing now...

              Show
              skodak Petr Skoda added a comment - I think Martin fixed it today, seems to work fine, closing now...
              Hide
              sbourget Stephen Bourget added a comment -

              While testing on moodle 1.7beta + (CVS checkout from 11/1/2006)

              The following errors are displayed while viewing the RSS from a specific user:

              Notice: Trying to get property of non-object in C:\WebSites\Moodle17\lib\accesslib.php on line 1027

              Warning: Cannot modify header information - headers already sent by (output started at C:\WebSites\Moodle17\lib\accesslib.php:1027) in C:\WebSites\Moodle17\lib\filelib.php on line 241
              http://10.0.64.20/moodle17/blog/index.php This RSS feed was automatically generated from one or more blogs. Moodle © 2006 TEST http://10.0.64.20/moodle17/pix/i/rsssitelogo.gif http://10.0.64.20/moodle17 140 35

              Steps to recreate the error:

              1. Set Blog Level to "The world can read entries set to be world-accessible"

              2. Set debugging to Normal

              3. Using an account that has permissions to create blogs (I used the Admin account) create a blog.

              4. Set the blog to be viewable by everyone (publish to anyone in the world) and save the blog

              5. Call cron.php to rebuild the RSS feeds

              6. Click on the RSS button on the blogs tab of the users profile

              7. The feed will be displayed with the errors shown above.

              Show
              sbourget Stephen Bourget added a comment - While testing on moodle 1.7beta + (CVS checkout from 11/1/2006) The following errors are displayed while viewing the RSS from a specific user: Notice: Trying to get property of non-object in C:\WebSites\Moodle17\lib\accesslib.php on line 1027 Warning: Cannot modify header information - headers already sent by (output started at C:\WebSites\Moodle17\lib\accesslib.php:1027) in C:\WebSites\Moodle17\lib\filelib.php on line 241 http://10.0.64.20/moodle17/blog/index.php This RSS feed was automatically generated from one or more blogs. Moodle © 2006 TEST http://10.0.64.20/moodle17/pix/i/rsssitelogo.gif http://10.0.64.20/moodle17 140 35 Steps to recreate the error: 1. Set Blog Level to "The world can read entries set to be world-accessible" 2. Set debugging to Normal 3. Using an account that has permissions to create blogs (I used the Admin account) create a blog. 4. Set the blog to be viewable by everyone (publish to anyone in the world) and save the blog 5. Call cron.php to rebuild the RSS feeds 6. Click on the RSS button on the blogs tab of the users profile 7. The feed will be displayed with the errors shown above.
              Hide
              poltawski Dan Poltawski added a comment -

              Verified with just updated CVS

              Show
              poltawski Dan Poltawski added a comment - Verified with just updated CVS
              Hide
              skodak Petr Skoda added a comment -

              I works for me in php 5.1.6, what PHP version are you using?

              Maybe the attached patch could solve it.

              Show
              skodak Petr Skoda added a comment - I works for me in php 5.1.6, what PHP version are you using? Maybe the attached patch could solve it.
              Hide
              sbourget Stephen Bourget added a comment -

              Database: MySQL 4.1.21
              PHP 5.1.4
              Server Apache 2.0.58
              Server OS: Windows Server 2003

              I've applied the patch and it allows the blog to be added to the RSS feed, However the errors are still shown.

              The new output is:

              Notice: Trying to get property of non-object in C:\WebSites\Moodle17\lib\accesslib.php on line 1028

              Warning: Cannot modify header information - headers already sent by (output started at C:\WebSites\Moodle17\lib\accesslib.php:1028) in C:\WebSites\Moodle17\lib\filelib.php on line 241
              http://10.0.64.20/moodle17/blog/index.php This RSS feed was automatically generated from one or more blogs. Moodle © 2006 TEST http://10.0.64.20/moodle17/pix/i/rsssitelogo.gif http://10.0.64.20/moodle17 140 35 http://10.0.64.20/moodle17/blog/index.php?postid=1 Wed, 01 Nov 2006 07:59:26 EST by Admin User.  <p> BLOG,BLOG,BLOG,BLOG </p> http://10.0.64.20/moodle17/blog/index.php?postid=1

              I'll attach the XML Document

              Show
              sbourget Stephen Bourget added a comment - Database: MySQL 4.1.21 PHP 5.1.4 Server Apache 2.0.58 Server OS: Windows Server 2003 I've applied the patch and it allows the blog to be added to the RSS feed, However the errors are still shown. The new output is: Notice: Trying to get property of non-object in C:\WebSites\Moodle17\lib\accesslib.php on line 1028 Warning: Cannot modify header information - headers already sent by (output started at C:\WebSites\Moodle17\lib\accesslib.php:1028) in C:\WebSites\Moodle17\lib\filelib.php on line 241 http://10.0.64.20/moodle17/blog/index.php This RSS feed was automatically generated from one or more blogs. Moodle © 2006 TEST http://10.0.64.20/moodle17/pix/i/rsssitelogo.gif http://10.0.64.20/moodle17 140 35 http://10.0.64.20/moodle17/blog/index.php?postid=1 Wed, 01 Nov 2006 07:59:26 EST by Admin User.  <p> BLOG,BLOG,BLOG,BLOG </p> http://10.0.64.20/moodle17/blog/index.php?postid=1 I'll attach the XML Document
              Hide
              sbourget Stephen Bourget added a comment -

              Actual XML file built from blog

              Show
              sbourget Stephen Bourget added a comment - Actual XML file built from blog
              Hide
              poltawski Dan Poltawski added a comment -

              Same error here too.

              Linux
              PHP 5.1.4
              apache 1.3

              Show
              poltawski Dan Poltawski added a comment - Same error here too. Linux PHP 5.1.4 apache 1.3
              Hide
              skodak Petr Skoda added a comment -

              I do not know why my test server is not displaying the notices, but I found the source of the problem - the access control in rss/file.php: it uses nomoodlecookie and at the same time capability checks.

              I am working on a solution now...

              Show
              skodak Petr Skoda added a comment - I do not know why my test server is not displaying the notices, but I found the source of the problem - the access control in rss/file.php: it uses nomoodlecookie and at the same time capability checks. I am working on a solution now...
              Hide
              skodak Petr Skoda added a comment -

              I hope this patch should solve it for now, could you please test it? thanks!

              Show
              skodak Petr Skoda added a comment - I hope this patch should solve it for now, could you please test it? thanks!
              Hide
              poltawski Dan Poltawski added a comment -

              looks good to me

              Show
              poltawski Dan Poltawski added a comment - looks good to me
              Hide
              skodak Petr Skoda added a comment -

              The last patch is committed into cvs, please reopen if you find any other related problem or if the patch does not work.

              Thanks everybody for the cooperating on this problem!!

              Show
              skodak Petr Skoda added a comment - The last patch is committed into cvs, please reopen if you find any other related problem or if the patch does not work. Thanks everybody for the cooperating on this problem!!
              Hide
              sbourget Stephen Bourget added a comment -

              Verified in moodle 1.7beta +

              Closing

              Show
              sbourget Stephen Bourget added a comment - Verified in moodle 1.7beta + Closing

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    7/Nov/06