Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-72438

Moodle 4.4. Final deprecation in core_question

XMLWordPrintable

    • MOODLE_400_STABLE, MOODLE_404_STABLE
    • MOODLE_404_STABLE
    • Hide

      Automated testing:

      1. PHPUnit passes
      2. Behat passes

      Manual testing

      1. Execute the following: 

        $ git grep -A1 "\( question_preview_url\| question_preview_popup_params\|question_hash\| question_make_export_url\| question_get_export_single_question_url\|question_get_export_single_question_url\|question_remove_stale_questions_from_category\|flatten_category_tree\| add_indented_names\| question_category_select_menu\| get_categories_for_contexts\| question_category_options\| question_add_context_in_key\| question_fix_top_names\|get_slot_tags_for_slot_id\|quiz_retrieve_tags_for_slot_ids\|submit_tags_form\|get_bulk_action_key\|preview_question_url\|process_actions\|process_actions_needing_ui\| question_is_only_child_of_top_category_in_context\|question_is_top_category\|question_can_delete_cat\| print_choose_qtype_to_add_form\| create_new_question_button\|question_preview_link\|core_question_output_fragment_tags_form\|render_qbank_chooser\|question_hash\| qbank_chooser\|qbank_chooser_types\|qbank_chooser_qtype\|qbank_chooser_title\| question_preview_question_pluginfile\| question_preview_action_url\| question_preview_form_url\| restart_preview\)" -- ":(exclude)lib/listlib.php" ":(exclude)mod/quiz/classes/local/reports/attempts_report.php" ":(exclude)mod/quiz/classes/question/bank/filter/custom_category_condition_helper.php" ":(exclude)mod/quiz/report/*" ":(exclude)question/bank/editquestion/*" ":(exclude)question/bank/exportquestions/*" ":(exclude)question/bank/exporttoxml/*" ":(exclude)question/bank/managecategories/*" ":(exclude)question/bank/previewquestion/*" ":(exclude)question/bank/tagquestion/*" ":(exclude)question/behaviour/*" ":(exclude)question/type/*" ":(exclude)lib/form/questioncategory.php" ":(exclude)lib/deprecatedlib.php" ":(exclude)mod/quiz/classes/output/renderer.php" ":(exclude)mod/quiz/classes/quiz_attempt.php"   

      2. Confirm it returns only function stubs (that throw exception), and upgrade notes regarding the functions
      3. Execute the following: 

        $ git log --diff-filter=D --summary --oneline -- question/category_class.php
        $ git log --diff-filter=D --summary --oneline -- question/category_form.php
        $ git log --diff-filter=D --summary --oneline -- question/export_form.php
        $ git log --diff-filter=D --summary --oneline -- question/import_form.php
        $ git log --diff-filter=D --summary --oneline -- question/move_form.php
        $ git log --diff-filter=D --summary --oneline -- question/previewlib.php
        $ git log --diff-filter=D --summary --oneline -- question/yui/src/preview/js/preview.js
        $ git log --diff-filter=D --summary --oneline -- question/amd/src/selectors.js
        $ git log --diff-filter=D --summary --oneline -- question/amd/src/repository.js
        $ git log --diff-filter=D --summary --oneline -- question/amd/src/edit_tags.js   

      4. Confirm it returns only "delete mode 100644 <filename>"
      Show
      Automated testing: PHPUnit passes Behat passes Manual testing Execute the following:  $ git grep -A1 "\( question_preview_url\| question_preview_popup_params\|question_hash\| question_make_export_url\| question_get_export_single_question_url\|question_get_export_single_question_url\|question_remove_stale_questions_from_category\|flatten_category_tree\| add_indented_names\| question_category_select_menu\| get_categories_for_contexts\| question_category_options\| question_add_context_in_key\| question_fix_top_names\|get_slot_tags_for_slot_id\|quiz_retrieve_tags_for_slot_ids\|submit_tags_form\|get_bulk_action_key\|preview_question_url\|process_actions\|process_actions_needing_ui\| question_is_only_child_of_top_category_in_context\|question_is_top_category\|question_can_delete_cat\| print_choose_qtype_to_add_form\| create_new_question_button\|question_preview_link\|core_question_output_fragment_tags_form\|render_qbank_chooser\|question_hash\| qbank_chooser\|qbank_chooser_types\|qbank_chooser_qtype\|qbank_chooser_title\| question_preview_question_pluginfile\| question_preview_action_url\| question_preview_form_url\| restart_preview\)" -- ":(exclude)lib/listlib.php" ":(exclude)mod/quiz/classes/local/reports/attempts_report.php" ":(exclude)mod/quiz/classes/question/bank/filter/custom_category_condition_helper.php" ":(exclude)mod/quiz/report/*" ":(exclude)question/bank/editquestion/*" ":(exclude)question/bank/exportquestions/*" ":(exclude)question/bank/exporttoxml/*" ":(exclude)question/bank/managecategories/*" ":(exclude)question/bank/previewquestion/*" ":(exclude)question/bank/tagquestion/*" ":(exclude)question/behaviour/*" ":(exclude)question/type/*" ":(exclude)lib/form/questioncategory.php" ":(exclude)lib/deprecatedlib.php" ":(exclude)mod/quiz/classes/output/renderer.php" ":(exclude)mod/quiz/classes/quiz_attempt.php" Confirm it returns only function stubs (that throw exception), and upgrade notes regarding the functions Execute the following:  $ git log --diff-filter=D --summary --oneline -- question/category_class.php $ git log --diff-filter=D --summary --oneline -- question/category_form.php $ git log --diff-filter=D --summary --oneline -- question/export_form.php $ git log --diff-filter=D --summary --oneline -- question/import_form.php $ git log --diff-filter=D --summary --oneline -- question/move_form.php $ git log --diff-filter=D --summary --oneline -- question/previewlib.php $ git log --diff-filter=D --summary --oneline -- question/yui/src/preview/js/preview.js $ git log --diff-filter=D --summary --oneline -- question/amd/src/selectors.js $ git log --diff-filter=D --summary --oneline -- question/amd/src/repository.js $ git log --diff-filter=D --summary --oneline -- question/amd/src/edit_tags.js Confirm  it returns only "delete mode 100644 <filename>"
    • 3
    • Team Alpha - Sprint 2 I1-2024

      Creating this issue to proceed with the final deprecation of functions in question/ due the changes done in: https://tracker.moodle.org/browse/MDL-70329
       

       

            mathewmay Mathew May
            safatshahin Safat Shahin
            Mihail Geshoski Mihail Geshoski
            Tim Hunt Tim Hunt
            Ron Carl Alfon Yu Ron Carl Alfon Yu
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 day, 3 hours, 26 minutes
                1d 3h 26m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.