-
Bug
-
Resolution: Fixed
-
Minor
-
3.9.9, 3.10.6, 3.11.2, 4.0
-
MOODLE_310_STABLE, MOODLE_311_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE
-
MOODLE_310_STABLE, MOODLE_311_STABLE, MOODLE_39_STABLE
-
MDL-72478-master -
- Check the GitHub Action is passing for all the branches. With this patch, the error with test_yearly_every_20th_monday_forever in the PHPUnit job for PHP8 (ubuntu-18.04, 8, pgsql, xmlrpc-beta) should not be displayed.
-
Moppies Kanban
With PHP 8.0.10 we've started getting PHPUnit failures when running the following method:
1) core_calendar_rrule_manager_testcase::test_yearly_every_20th_monday_forever |
Failed asserting that two strings are equal.
|
--- Expected
|
+++ Actual
|
@@ @@
|
-'2022-05-16 18:00:00' |
+'2022-05-16 09:00:00' |
Eloy has detected that it's due to some changes done in datetime->modify()
Before PHP 8.0.10… the time is lost when datetime->modify() is used with weekdays. With PHP 8.0.10… it’s kept. https://3v4l.org/PEFkJ
