Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-7255

Potentially move the sql_primary_role_subselect() function to datalib

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.7
    • Fix Version/s: 1.9
    • Labels:
      None
    • Environment:
      Any
    • Database:
      Any
    • Affected Branches:
      MOODLE_17_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE

      Description

      Currently there is one function in dmllib.php that, IMO, should be in other lib (going to datalib if it's considered central and doesn't fit in onother lib):

      sql_primary_role_subselect()

      The basic idea is to leave dmllib only for select/insert/update/delete statements (and underlying compatibility functions), while all the rest of db related functions that performs "non-generic" acctions should go to their own library(course/lib.php, accesslib.php...) ot to datalib.php if they doesn't have a better place.

      Not critical at all!

        Attachments

          Activity

            People

            Assignee:
            stronk7 Eloy Lafuente (stronk7)
            Reporter:
            stronk7 Eloy Lafuente (stronk7)
            Tester:
            Nobody
            Participants:
            Component watchers:
            Andrew Nicols, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              3/Mar/08