Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-72605

Scenario: Add blocks to page failing under classic

    XMLWordPrintable

    Details

    • Sprint:
      Moppies Kanban

      Description

      This is a followup / regression of MDL-72116, where a scenario under classic is failing consistently (master only):

      Link: https://ci.moodle.org/job/W.05.01%20-%20Behat%20-%20Goutte%20+%20Postgres%20+%20Classic/1024/

      001 Scenario: Add blocks to page             # /var/www/html/my/tests/behat/add_blocks.feature:21
            And I should not see "Upcoming events" # /var/www/html/my/tests/behat/add_blocks.feature:27
              "Upcoming events" text was found in the page (Behat\Mink\Exception\ExpectationException)
      

      And bisect section pointed to MDL-72116:

      4cb297d4fd05c6c02ab7b1329da18f36bfad6a60 is the first bad commit
      commit 4cb297d4fd05c6c02ab7b1329da18f36bfad6a60
      Author: Sara Arjona <sara@moodle.com>
      Date:   Fri Aug 13 12:24:36 2021 +0200
       
          MDL-72116 dashboard: Remove some of the current blocks
          
          The following blocks have been removed from the Dashboard:
          - Online users
          - Upcoming events
          - Learning plans
          - Recently accessed courses
          
          This change will only apply on new installations.
       
       admin/tool/behat/tests/behat/i_am_on_page.feature  |  4 ++--
       admin/tool/lp/tests/behat/plan_workflow.feature    |  3 +++
       .../behat/block_calendar_upcoming_course.feature   |  3 +++
       blocks/calendar_upcoming/tests/generator/lib.php   | 26 ++++++++++++++++++++++
       blocks/lp/tests/generator/lib.php                  | 26 ++++++++++++++++++++++
       .../tests/behat/block_online_users_course.feature  |  1 +
       .../behat/block_online_users_dashboard.feature     |  3 +++
       .../behat/block_online_users_frontpage.feature     |  1 +
       ...block_recentlyaccessedcourses_dashboard.feature |  3 +++
       .../tests/generator/lib.php                        | 26 ++++++++++++++++++++++
       blocks/tests/externallib_test.php                  | 19 ++++++++--------
       lib/blocklib.php                                   |  4 ++--
       my/tests/behat/add_blocks.feature                  |  2 +-
       my/tests/behat/reset_all_pages.feature             | 12 +++++-----
       my/tests/behat/reset_page.feature                  |  2 +-
       15 files changed, 113 insertions(+), 22 deletions(-)
       create mode 100644 blocks/calendar_upcoming/tests/generator/lib.php
       create mode 100644 blocks/lp/tests/generator/lib.php
       create mode 100644 blocks/recentlyaccessedcourses/tests/generator/lib.php
      

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              sarjona Sara Arjona (@sarjona)
              Reporter:
              stronk7 Eloy Lafuente (stronk7)
              Peer reviewer:
              Carlos Escobedo Carlos Escobedo
              Integrator:
              Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
              Tester:
              CiBoT CiBoT
              Participants:
              Component watchers:
              Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 40 minutes
                  40m