Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-72642

Duplicate id when there is multiple nav bars

    XMLWordPrintable

    Details

    • Affected Branches:
      MOODLE_400_STABLE
    • Fixed Branches:
      MOODLE_400_STABLE
    • Pull Master Branch:
      MDL-72642-master
    • Testing Instructions:
      Hide
      1. Login as Admin
      2. Create a Course.
      3. Go to the course homepage
      4. Reduce the screen resolution to a point where you can see the "More" menu in both primary and the course secondary navigation.
      5. Inspect both navigation menus (primary and course secondary) and it's items
        1. confirm that there aren't any duplicated 'id' attributes used by both menus

      Alternatively, you can copy the source code from the course homepage and use a HTML validator (https://validator.w3.org/) to check the markup:

      • confirm that there isn't any errors reported due to duplicated ID's
      Show
      Login as Admin Create a Course. Go to the course homepage Reduce the screen resolution to a point where you can see the "More" menu in both primary and the course secondary navigation. Inspect both navigation menus (primary and course secondary) and it's items confirm that there aren't any duplicated 'id' attributes used by both menus Alternatively, you can copy the source code from the course homepage and use a HTML validator ( https://validator.w3.org/ ) to check the markup: confirm that there isn't any errors reported due to duplicated ID's
    • Sprint:
      Navigation push 6

      Description

      If the site has a custom menu set and you are on a course page, then you would have a duplicate id for the 'more' menu items.

      This is because of the uniqid usage in the lib/templates/moremenu.mustache template.

      please note that the uniqid mustache helper always gives the same id during a call to render.

       

        Attachments

          Activity

            People

            Assignee:
            Geshoski Mihail Geshoski
            Reporter:
            rezaie9 Shamim Rezaie
            Peer reviewer:
            Sujith Haridasan Sujith Haridasan
            Integrator:
            Andrew Lyons Andrew Lyons
            Tester:
            Gladys Basiana Gladys Basiana
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours, 25 minutes
                2h 25m