Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-72675

Picasa repository not fully removed by MDL-58939

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 4.0
    • Fix Version/s: 4.0
    • Labels:
    • Affected Branches:
      MOODLE_400_STABLE
    • Fixed Branches:
      MOODLE_400_STABLE
    • Pull Master Branch:
    • Testing Instructions:
      Hide
      1. Run the following SQL query:

        SELECT * FROM `moodle`.mdl_config_plugins
        WHERE plugin LIKE '%picasa%';

      2. Confirm there is a plugin record for repository_picasa
      3. Run upgrade step
      4. Re-run query, confirm the plugin record has been removed
      Show
      Run the following SQL query: SELECT * FROM `moodle`.mdl_config_plugins WHERE plugin LIKE '%picasa%'; Confirm there is a plugin record for repository_picasa Run upgrade step Re-run query, confirm the plugin record has been removed

      Description

      When the picasa repository was removed in MDL-58939 it didn't fully remove the plugins configuration, meaning every time there's a version bump on the site, I'm prompted to uninstall the plugin again - but it never appears to succeed:

      We should remove the correct configuration here: https://github.com/moodle/moodle/blob/214adb798498741f9ddfe3533efcb106db8ad6ec/lib/db/upgrade.php#L2826-L2827 ('repository_picasa')

      The testing instructions on MDL-58939 have the step:

      Check the following SQL query is not empty: 
       
      SELECT * FROM mdl_config_plugins WHERE plugin = 'picasa'

      But that plugin doesn't exist, nor appear to return any records on current 311_STABLE branch, which is a bit confusing

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              pholden Paul Holden
              Reporter:
              pholden Paul Holden
              Peer reviewer:
              Carlos Escobedo Carlos Escobedo
              Integrator:
              Ilya Tregubov Ilya Tregubov
              Tester:
              Angelia Dela Cruz Angelia Dela Cruz
              Participants:
              Component watchers:
              Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 32 minutes
                  32m