[MDL-72675] Picasa repository not fully removed by MDL-58939 - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 4.0
Fix Version/s: 4.0
Component/s: Administration, Repositories
Labels:
- ci

Affected Branches:
MOODLE_400_STABLE
Fixed Branches:
MOODLE_400_STABLE
Pull from Repository:
git://github.com/paulholden/moodle.git
Pull Master Branch:
~~MDL-72675~~
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...paulholden:MDL-72675
Testing Instructions:
Hide

Run the following SQL query:

SELECT * FROM `moodle`.mdl_config_plugins

WHERE plugin LIKE '%picasa%';

Confirm there is a plugin record for repository_picasa

Run upgrade step

Re-run query, confirm the plugin record has been removed
Show
Run the following SQL query: SELECT * FROM `moodle`.mdl_config_plugins WHERE plugin LIKE '%picasa%'; Confirm there is a plugin record for repository_picasa Run upgrade step Re-run query, confirm the plugin record has been removed

Description

When the picasa repository was removed in ~~MDL-58939~~ it didn't fully remove the plugins configuration, meaning every time there's a version bump on the site, I'm prompted to uninstall the plugin again - but it never appears to succeed:

We should remove the correct configuration here: https://github.com/moodle/moodle/blob/214adb798498741f9ddfe3533efcb106db8ad6ec/lib/db/upgrade.php#L2826-L2827 ('repository_picasa')

The testing instructions on ~~MDL-58939~~ have the step:

Check the following SQL query is not empty:

SELECT * FROM mdl_config_plugins WHERE plugin = 'picasa'

But that plugin doesn't exist, nor appear to return any records on current 311_STABLE branch, which is a bit confusing

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

MDL-72675_after.png
51 kB
30/Sep/21 9:19 AM
MDL-72675_before.png
57 kB
30/Sep/21 9:19 AM
Screenshot_2021-09-24 Plugins check.png
51 kB
24/Sep/21 7:37 PM

Issue Links

has a non-specific relationship to

MDL-77598 Complete plugin uninstallation from MDL-52805 & MDL-77308

Closed

is a regression caused by

MDL-58939 Remove picasa repository and portfolio from core

Closed

Activity

People

Assignee:: Paul Holden

Reporter:: Paul Holden

Peer reviewer:: Carlos Escobedo

Integrator:: Ilya Tregubov

Tester:: Angelia Dela Cruz

Participants:: Angelia Dela Cruz, Carlos Escobedo, CiBoT, Ilya Tregubov, Paul Holden

Component watchers:: David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 6 Start watching this issue

Dates

Created:: 24/Sep/21 7:29 PM

Updated:: 11/Mar/23 12:10 AM

Resolved:: 03/Oct/21 4:31 AM

Fix Release Date:: 19/Apr/22

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

32m