Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-72675

Picasa repository not fully removed by MDL-58939

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 4.0
    • 4.0
    • MOODLE_400_STABLE
    • MOODLE_400_STABLE
    • Hide
      1. Run the following SQL query:

        SELECT * FROM `moodle`.mdl_config_plugins
        WHERE plugin LIKE '%picasa%';

      2. Confirm there is a plugin record for repository_picasa
      3. Run upgrade step
      4. Re-run query, confirm the plugin record has been removed
      Show
      Run the following SQL query: SELECT * FROM `moodle`.mdl_config_plugins WHERE plugin LIKE '%picasa%'; Confirm there is a plugin record for repository_picasa Run upgrade step Re-run query, confirm the plugin record has been removed

    Description

      When the picasa repository was removed in MDL-58939 it didn't fully remove the plugins configuration, meaning every time there's a version bump on the site, I'm prompted to uninstall the plugin again - but it never appears to succeed:

      We should remove the correct configuration here: https://github.com/moodle/moodle/blob/214adb798498741f9ddfe3533efcb106db8ad6ec/lib/db/upgrade.php#L2826-L2827 ('repository_picasa')

      The testing instructions on MDL-58939 have the step:

      Check the following SQL query is not empty: 
       
      SELECT * FROM mdl_config_plugins WHERE plugin = 'picasa'

      But that plugin doesn't exist, nor appear to return any records on current 311_STABLE branch, which is a bit confusing

      Attachments

        Issue Links

          Activity

            People

              pholden Paul Holden
              pholden Paul Holden
              Carlos Escobedo Carlos Escobedo
              Ilya Tregubov Ilya Tregubov
              Angelia Dela Cruz Angelia Dela Cruz
              David Woloszyn, Huong Nguyen, Jake Dallimore, Michael Hawkins, Stevani Andolo, David Woloszyn, Huong Nguyen, Jake Dallimore, Michael Hawkins, Stevani Andolo
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                19/Apr/22

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 32 minutes
                  32m