Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-72682

Indicator for when report filters form contains instances that are active

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 4.0
    • Fix Version/s: 4.0
    • Component/s: Report builder
    • Labels:
    • Affected Branches:
      MOODLE_400_STABLE
    • Fixed Branches:
      MOODLE_400_STABLE
    • Pull Master Branch:
    • Testing Instructions:
      Hide

      Manual test

      1. Navigate to Server > Tasks > Task logs in site administration
      2. Press Filters
      3. Set Result is equal to: Success and press apply
      4. Confirm the filters button shows Filters (1)
      5. Set Name contains: Cron and press apply
      6. Confirm the filters button shows Filters (2)
      7. Reload the page
      8. Confirm the filters button shows Filters (2)
      9. Press Filters (2)
      10. Press Reset all
      11. Confirm the filters button shows Filters

      Automated test

      $ bin/moodle-docker-compose exec --user www-data webserver php admin/tool/behat/cli/run.php --name="View task logs report and use its filters"
      

      Show
      Manual test Navigate to Server > Tasks > Task logs in site administration Press Filters Set Result is equal to: Success and press apply Confirm the filters button shows Filters (1) Set Name contains: Cron and press apply Confirm the filters button shows Filters (2) Reload the page Confirm the filters button shows Filters (2) Press Filters (2) Press Reset all Confirm the filters button shows Filters Automated test $ bin/moodle-docker-compose exec --user www-data webserver php admin/tool/behat/cli/run.php --name="View task logs report and use its filters"

      Description

      It would be nice if when using Report builder, the Filters button indicated the number of active filters (where "active" means the filter is currently being applied to the report/returning some SQL)

      Rafael Lechugo's mockup/comment follows:

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              pholden Paul Holden
              Reporter:
              pholden Paul Holden
              Peer reviewer:
              David Matamoros David Matamoros
              Integrator:
              Jun Pataleta Jun Pataleta
              Tester:
              Angelia Dela Cruz Angelia Dela Cruz
              Participants:
              Component watchers:
              David Matamoros, Paul Holden
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 hours, 40 minutes
                  2h 40m