Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-72682

Indicator for when report filters form contains instances that are active

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 4.0
    • 4.0
    • Report builder
    • MOODLE_400_STABLE
    • MOODLE_400_STABLE
    • Hide

      Manual test

      1. Navigate to Server > Tasks > Task logs in site administration
      2. Press Filters
      3. Set Result is equal to: Success and press apply
      4. Confirm the filters button shows Filters (1)
      5. Set Name contains: Cron and press apply
      6. Confirm the filters button shows Filters (2)
      7. Reload the page
      8. Confirm the filters button shows Filters (2)
      9. Press Filters (2)
      10. Press Reset all
      11. Confirm the filters button shows Filters

      Automated test

      $ bin/moodle-docker-compose exec --user www-data webserver php admin/tool/behat/cli/run.php --name="View task logs report and use its filters"

      Show
      Manual test Navigate to Server > Tasks > Task logs in site administration Press Filters Set Result is equal to: Success and press apply Confirm the filters button shows Filters (1) Set Name contains: Cron and press apply Confirm the filters button shows Filters (2) Reload the page Confirm the filters button shows Filters (2) Press Filters (2) Press Reset all Confirm the filters button shows Filters Automated test $ bin/moodle-docker-compose exec --user www-data webserver php admin/tool/behat/cli/run.php --name="View task logs report and use its filters"

    Description

      It would be nice if when using Report builder, the Filters button indicated the number of active filters (where "active" means the filter is currently being applied to the report/returning some SQL)

      rafaellechugo's mockup/comment follows:

      Attachments

        1. MDL-72682_Automated Test.png
          57 kB
          Angelia Dela Cruz
        2. MDL-72682_Manual Test_Step 11.png
          151 kB
          Angelia Dela Cruz
        3. MDL-72682_Manual Test_Step 4.png
          153 kB
          Angelia Dela Cruz
        4. MDL-72682_Manual Test_Step 6.png
          156 kB
          Angelia Dela Cruz
        5. MDL-72682_Manual Test_Step 8.png
          56 kB
          Angelia Dela Cruz
        6. Screenshot from 2021-09-27 13-09-18.png
          51 kB
          Paul Holden

        Issue Links

          is blocked by

          Improvement - An enhancement to an existing Moodle feature. MDL-72545 Reload report filter form via fragment when resetting, avoid page reload

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              pholden Paul Holden
              pholden Paul Holden
              David Carrillo David Carrillo
              Jun Pataleta Jun Pataleta
              Angelia Dela Cruz Angelia Dela Cruz
              David Carrillo, Paul Holden
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                19/Apr/22

                Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 hours, 40 minutes
                  2h 40m