Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-72725

Add legacy indentation for third course format plugins

    XMLWordPrintable

Details

    • MOODLE_400_STABLE
    • MOODLE_400_STABLE
    • MDL-72725-master
    • Hide

      Test 1: core format

      1. Create a course in topics format with some activities
        1. Check the activities menu does not have move right or move left options
      2. Create weeks format course with some activities
        1. Check the activities menu does not have move right or move left options

      Test 2: already created courses

      1. Restore the attached course backup MDL-72725_indented_course.mbz
      2. Go to the restored course
        1. Check no activity is indented
        2. Check the activities menu does not have move right or move left options

      Test 3: contrib formats

      The test asks you to install collapsed topic but any other format with indentation could be used (grid, for example)

      1. Install this course format plugin: https://moodle.org/plugins/format_topcoll
      2. Create a course in that format and add some activities
      3. Indent one activity right
        1. Check the activity is indented right
      4. Indent the same activity left
        1. Check the activity is indented left
      Show
      Test 1: core format Create a course in topics format with some activities Check the activities menu does not have move right or move left options Create weeks format course with some activities Check  the activities menu does not have move right or move left options Test 2: already created courses Restore the attached course backup  MDL-72725_indented_course.mbz Go to the restored course Check no activity is indented Check  the activities menu does not have move right or move left options Test 3: contrib formats The test asks you to install collapsed topic but any other format with indentation could be used (grid, for example) Install this course format plugin: https://moodle.org/plugins/format_topcoll Create a course in that format and add some activities Indent one activity right Check the activity is indented right Indent the same activity left Check the activity is indented left
    • Moppies Kanban

    Description

      In 4.0 we have removed the indentation for Topics and Weekly formats. While the existing indentation options are powerful, it also creates the potential for overuse and creating a cluttered course appearance. This is not consistent with the 4.0 design approach of displaying activities in a 'card-like' format. For Moodle 4.0 recommended approaches to bring some hierarchy in the course are by using sections and using some recommended strategies to streamline course pages (this page will also be updated for 4.0). Further strategies to create different levels of hierarchy in a course will be explored for following releases. In the meantime, we are preserving the indentation options for 3rd party course formats, so that they can continue to utilise these as desired.

      In order to keep the indentation for third course format plugins, we should add a new public function in course/format/classes/base.php which would be easy to overwrite to set if our course format has an indentation or not.

      public function uses_indentation() {
          return false;
      }
      

      Also, to make life easier for community developers, this public function returns a true default value. This way, only community developers have to overwrite the function if they won't keep the indentation.

      So, topics and weekly formats will overwrite this function to set to false.

       

       

      Attachments

        Issue Links

          Activity

            People

              tusefomal Ferran Recio
              cescobedo Carlos Escobedo
              Carlos Escobedo Carlos Escobedo
              Andrew Lyons Andrew Lyons
              Gladys Basiana Gladys Basiana
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 6 hours, 20 minutes
                  6h 20m