-
Improvement
-
Resolution: Fixed
-
Minor
-
4.0
-
MOODLE_400_STABLE
-
MOODLE_400_STABLE
-
MDL-72725-master -
Test 1: core format
- Create a course in topics format with some activities
- Check the activities menu does not have move right or move left options
- Create weeks format course with some activities
- Check the activities menu does not have move right or move left options
Test 2: already created courses
- Restore the attached course backup MDL-72725_indented_course.mbz
- Go to the restored course
- Check no activity is indented
- Check the activities menu does not have move right or move left options
Test 3: contrib formats
The test asks you to install collapsed topic but any other format with indentation could be used (grid, for example)
- Install this course format plugin: https://moodle.org/plugins/format_topcoll
- Create a course in that format and add some activities
- Indent one activity right
- Check the activity is indented right
- Indent the same activity left
- Check the activity is indented left
Test 1: core format Create a course in topics format with some activities Check the activities menu does not have move right or move left options Create weeks format course with some activities Check the activities menu does not have move right or move left options Test 2: already created courses Restore the attached course backup MDL-72725_indented_course.mbz Go to the restored course Check no activity is indented Check the activities menu does not have move right or move left options Test 3: contrib formats The test asks you to install collapsed topic but any other format with indentation could be used (grid, for example) Install this course format plugin: https://moodle.org/plugins/format_topcoll Create a course in that format and add some activities Indent one activity right Check the activity is indented right Indent the same activity left Check the activity is indented left - Create a course in topics format with some activities
-
Moppies Kanban
In 4.0 we have removed the indentation for Topics and Weekly formats. While the existing indentation options are powerful, it also creates the potential for overuse and creating a cluttered course appearance. This is not consistent with the 4.0 design approach of displaying activities in a 'card-like' format. For Moodle 4.0 recommended approaches to bring some hierarchy in the course are by using sections and using some recommended strategies to streamline course pages (this page will also be updated for 4.0). Further strategies to create different levels of hierarchy in a course will be explored for following releases. In the meantime, we are preserving the indentation options for 3rd party course formats, so that they can continue to utilise these as desired.
In order to keep the indentation for third course format plugins, we should add a new public function in course/format/classes/base.php which would be easy to overwrite to set if our course format has an indentation or not.
public function uses_indentation() { |
return false; |
}
|
Also, to make life easier for community developers, this public function returns a true default value. This way, only community developers have to overwrite the function if they won't keep the indentation.
So, topics and weekly formats will overwrite this function to set to false.
