Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-72774

Consistent layout/language strings in date-based filters

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 4.0
    • Fix Version/s: 4.0
    • Component/s: Report builder
    • Labels:
    • Affected Branches:
      MOODLE_400_STABLE
    • Fixed Branches:
      MOODLE_400_STABLE
    • Pull Master Branch:
    • Testing Instructions:
      Hide
      1. Navigate to Server > Tasks > Task Logs in site administration
      2. Press Filters button
      3. Set Start time filter to Previous
      4. Confirm text input field is visible, type "1" and select "week(s)" (or any value/unit combination that apply to your instance's logs) and press Apply
      5. Confirm only logs that match your filter are only listed.
      6. Set Start time filter to Current
      7. Confirm text input field is hidden, select "month(s)" and press Apply
      8. Confirm only logs from current month are listed
      9. Confirm the units for the Start time filter read "day(s); week(s); month(s); year(s)"
      10. Set Duration filter to Greater than
      11. Confirm the units for the Duration filter read "second(s); minute(s); hour(s); day(s)"
      Show
      Navigate to Server > Tasks > Task Logs in site administration Press Filters button Set Start time filter to Previous Confirm text input field is visible, type "1" and select "week(s)" (or any value/unit combination that apply to your instance's logs) and press Apply Confirm only logs that match your filter are only listed. Set Start time filter to Current Confirm text input field is hidden, select "month(s)" and press Apply Confirm only logs from current month are listed Confirm the units for the Start time filter read "day(s); week(s); month(s); year(s)" Set Duration filter to Greater than Confirm the units for the Duration filter read "second(s); minute(s); hour(s); day(s)"

      Description

      We should improve/fix the following:

      • Reduce spacing between elements (compare to Is equal to: Success);
      • Hide the unit value field in the date Current: [Unit] filter;
      • Make the unit lang strings consistent (currently a mix of Day(s) vs. days at the moment)

      For both the Date and Duration filter types

        Attachments

          Activity

            People

            Assignee:
            pholden Paul Holden
            Reporter:
            pholden Paul Holden
            Peer reviewer:
            David Matamoros David Matamoros
            Integrator:
            Jun Pataleta Jun Pataleta
            Tester:
            Gladys Basiana Gladys Basiana
            Participants:
            Component watchers:
            David Matamoros, Paul Holden
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours, 30 minutes
                2h 30m