Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-72788

Create a new renderable for the langmenu

    XMLWordPrintable

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 4.0
    • Fix Version/s: None
    • Component/s: Navigation
    • Labels:
      None
    • Affected Branches:
      MOODLE_400_STABLE

      Description

      In MDL-69371 a legacy style method was added to create a language menu

      ($OUTPUT->language_menu())

      We should not be introducing legacy style methods here that do not have a renderable / templatable class with an export_for_template method.

      We have the method lib/classes/navigation/output/primary.php - get_lang_menu(). Which would be ideal for getting the data needed for the login page and sent to an appropriate template. Unfortunately this is in a protected method. This should have been done in core where any component can get at it.

      We should have a proper language renderable that can be called by the primary navigation and the login page.

        Attachments

          Activity

            People

            Assignee:
            Unassigned Unassigned
            Reporter:
            basbrands Bas Brands
            Participants:
            Component watchers:
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: