Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-72789

Improve filtering by component in eventlist report

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Waiting for peer review
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 3.10.7
    • Fix Version/s: None
    • Component/s: Events API, Reports
    • Labels:
    • Affected Branches:
      MOODLE_310_STABLE
    • Pull from Repository:
    • Pull 3.11 Branch:
      MDL-72789-311
    • Pull Master Branch:
    • Testing Instructions:
      Hide

      Perform test on master (regression test) and 311

      1. Login as admin
      2. Navigate to Reports > Event list in site administration
      3. Set Component to "Activity modules > H5P" and press Filter
        • In 311 select "H5P" as there is no grouping by component type
      4. Confirm only events belonging to \mod_h5pactivity are listed (not those belonging to \core_h5p
      5. Set Component to "Core > Subsystem (core)" and press Filter
        • In 311 select "core" as there is no grouping by component type
      6. Confirm only events belonging to \core are listed (not those belonging to \core_customfield and \core_payment)
      7. Set Component to "Core > Subsystem (core_customfield)" and press Filter
        • In 311 select "core_customfield" as there is no grouping by component type
      8. Confirm only events belonging to \core_customfield are listed
      Show
      Perform test on master (regression test) and 311 Login as admin Navigate to Reports > Event list in site administration Set Component to "Activity modules > H5P" and press Filter In 311 select "H5P" as there is no grouping by component type Confirm only events belonging to \mod_h5pactivity are listed ( not those belonging to \core_h5p Set Component to "Core > Subsystem (core)" and press Filter In 311 select "core" as there is no grouping by component type Confirm only events belonging to \core are listed ( not those belonging to \core_customfield and \core_payment ) Set Component to "Core > Subsystem (core_customfield)" and press Filter In 311 select "core_customfield" as there is no grouping by component type Confirm only events belonging to \core_customfield are listed

      Description

      As pointed out by Víctor Déniz Falcón and Andrew Lyons in MDL-72498, the change in that issue has demonstrated some pre-existing problems in how components are filtered in the Event list report

      Performing partial matching on the selected Component filter field name means

      1. We get false positives (filtering by the H5P activity module returns both \core_h5 and \mod_h5pactivity events;
      2. Filtering by a subsystem doesn't match the component name in the table

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              pholden Paul Holden
              Reporter:
              pholden Paul Holden
              Peer reviewer:
              Mathew May Mathew May
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona), Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 15 minutes
                  1h 15m