Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-72789

Improve filtering by component in eventlist report

XMLWordPrintable

    • MOODLE_310_STABLE, MOODLE_311_STABLE
    • MOODLE_311_STABLE
    • Hide

      Perform test on master (regression test) and 311

      1. Login as admin
      2. Navigate to Reports > Event list in site administration
      3. Set Component to "Activity modules > H5P" and press Filter
        • In 311 select "H5P" as there is no grouping by component type
      4. Confirm only events belonging to \mod_h5pactivity are listed (not those belonging to \core_h5p
      5. Set Component to "Core > Subsystem (core)" and press Filter
        • In 311 select "core" as there is no grouping by component type
      6. Confirm only events belonging to \core are listed (not those belonging to \core_customfield and \core_payment)
      7. Set Component to "Core > Subsystem (core_customfield)" and press Filter
        • In 311 select "core_customfield" as there is no grouping by component type
      8. Confirm only events belonging to \core_customfield are listed
      Show
      Perform test on master (regression test) and 311 Login as admin Navigate to Reports > Event list in site administration Set Component to "Activity modules > H5P" and press Filter In 311 select "H5P" as there is no grouping by component type Confirm only events belonging to \mod_h5pactivity are listed ( not those belonging to \core_h5p Set Component to "Core > Subsystem (core)" and press Filter In 311 select "core" as there is no grouping by component type Confirm only events belonging to \core are listed ( not those belonging to \core_customfield and \core_payment ) Set Component to "Core > Subsystem (core_customfield)" and press Filter In 311 select "core_customfield" as there is no grouping by component type Confirm only events belonging to \core_customfield are listed

      As pointed out by vmdef and dobedobedoh in MDL-72498, the change in that issue has demonstrated some pre-existing problems in how components are filtered in the Event list report

      Performing partial matching on the selected Component filter field name means

      1. We get false positives (filtering by the H5P activity module returns both \core_h5 and \mod_h5pactivity events;
      2. Filtering by a subsystem doesn't match the component name in the table

        1. MDL-72789_master_Step 4.png
          MDL-72789_master_Step 4.png
          105 kB
        2. MDL-72789_master_Step 6.webm
          4.22 MB
        3. MDL-72789_master_Step 8.png
          MDL-72789_master_Step 8.png
          117 kB
        4. MDL-72789_v311_Step 4.png
          MDL-72789_v311_Step 4.png
          110 kB
        5. MDL-72789_v311_Step 6.webm
          4.23 MB
        6. MDL-72789_v311_Step 8.png
          MDL-72789_v311_Step 8.png
          121 kB

            pholden Paul Holden
            pholden Paul Holden
            Mathew May Mathew May
            Jun Pataleta Jun Pataleta
            Angelia Dela Cruz Angelia Dela Cruz
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours
                2h

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.