Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-72799

Follow up for navigation styling

    XMLWordPrintable

    Details

    • Affected Branches:
      MOODLE_400_STABLE
    • Fixed Branches:
      MOODLE_400_STABLE
    • Pull Master Branch:
    • Testing Instructions:
      Hide

      Requirements:

      1. Two users, Admin & Student One (S1)
      2. Course with topics format

      Setup:

      1. Log in as Admin
      2. Navigate to Student One profile page
      3. Send Student One a message

      Test:

      1. Confirm on any page that there is a notable gap between the site name and the Dashboard primary navigation node
      2. Navigate to the course
      3. Confirm that there is no extra border below the secondary navigation as pointed to in courseview.png
      4. Log out
      5. Go to the site home page
      6. Confirm that a divider does not exist beside the "You are not logged in. (Log in)"
      7. Log in as Student one
      8. Confirm you see a message notification
      9. Confirm that the alert for the message is closer to the message icon
      10. Log out
      11. Log in as Admin
      12. Navigate to site admin
      13. Click on Grades
      14. Confirm you see a blue border below grades
      15. Confirm That the font weight does not change on the selected tab
      16. Long click on grades to make the focus appear
      17. Confirm that the focus styling wraps around the tab & border
      18. Whilst Grades is focused, Hover over Courses and confirm the focus border on Grades remains uninterrupted
      19. Whilst Grades is focused, Hover over Plugins and confirm the focus border on Grades remains uninterrupted
      20. Shrink the screen so that the More menu appears in the secondary navigation
      21. Select Development from the More menu
      22. Once redirected click on the More menu
      23. Confirm that there is a checkmark next to development
      Show
      Requirements: Two users, Admin & Student One (S1) Course with topics format Setup: Log in as Admin Navigate to Student One profile page Send Student One a message Test: Confirm on any page that there is a notable gap between the site name and the Dashboard primary navigation node Navigate to the course Confirm that there is no extra border below the secondary navigation as pointed to in courseview.png Log out Go to the site home page Confirm that a divider does not exist beside the "You are not logged in. (Log in)" Log in as Student one Confirm you see a message notification Confirm that the alert for the message is closer to the message icon Log out Log in as Admin Navigate to site admin Click on Grades Confirm you see a blue border below grades Confirm That the font weight does not change on the selected tab Long click on grades to make the focus appear Confirm that the focus styling wraps around the tab & border Whilst Grades is focused, Hover over Courses and confirm the focus border on Grades remains uninterrupted Whilst Grades is focused, Hover over Plugins and confirm the focus border on Grades remains uninterrupted Shrink the screen so that the More menu appears in the secondary navigation Select Development from the More menu Once redirected click on the More menu Confirm that there is a checkmark next to development
    • Story Points:
      1
    • Sprint:
      Navigation push 7, Navigation push 8, Navigation push 9

      Description

      Here we can capture issues introduced by MDL-72091

      So far we have spotted: 

      1. The notification badge now seems a bit too high
      2. Course topic format
        1. There looks to be a double border up the top
        2. There's a missing bottom border for hidden sections
      3. Divider still exists when there is no edit toggle
      4. add a "mr-4" class in the site name or site logo, so it is not displayed too close from the primary navigation
      5. Secondary navigation elements should have square corners, even if bootstrap is configured to display rounded corners
      6. Active tabs have a different width from those tabs which is not active, we'll keep the same font-weight for active tabs
      7. Hover & hover active backgrounds should be $grey-100
      8. When something is selected in the more menu we need a tick (not blue highlighted cell)
      9. When focused, the secondary navigation does not have a consistent border width

        Attachments

        1. border-or-spacing-issue-1.png
          border-or-spacing-issue-1.png
          92 kB
        2. border-or-spacing-issue-2.png
          border-or-spacing-issue-2.png
          89 kB
        3. courseview.png
          courseview.png
          26 kB
        4. dashboard-empty-region.png
          dashboard-empty-region.png
          118 kB
        5. MDL-72799_C_000.png
          MDL-72799_C_000.png
          15 kB
        6. MDL-72799_C_001.png
          MDL-72799_C_001.png
          20 kB
        7. MDL-72799_C_002.png
          MDL-72799_C_002.png
          12 kB
        8. MDL-72799_Test Passed.png
          MDL-72799_Test Passed.png
          249 kB
        9. no-space-between-regions.png
          no-space-between-regions.png
          78 kB
        10. pagewidth.png
          pagewidth.png
          1.78 MB
        11. photo_2021-10-13 13.55.31.jpeg
          photo_2021-10-13 13.55.31.jpeg
          2 kB
        12. Screenshot from 2021-10-14 08-14-31.png
          Screenshot from 2021-10-14 08-14-31.png
          50 kB

          Issue Links

            Activity

              People

              Assignee:
              mathewmay Mathew May
              Reporter:
              mathewmay Mathew May
              Peer reviewer:
              Ferran Recio Ferran Recio
              Integrator:
              Shamim Rezaie Shamim Rezaie
              Tester:
              Gladys Basiana Gladys Basiana
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan, Huong Nguyen, Bas Brands, Mathew May
              Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 4 days, 4 hours, 56 minutes
                  4d 4h 56m