Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-72816

Ensure that navigation tabs are highlighted.

    XMLWordPrintable

    Details

    • Affected Branches:
      MOODLE_400_STABLE
    • Fixed Branches:
      MOODLE_400_STABLE
    • Pull Master Branch:
      MDL-72816-master-nov17
    • Testing Instructions:
      Hide

      Confirm behat test passes

      Prerequisites:

      1. Login as an admin
      2. Create a feedback activity on the site home
      3. Enable guest access and enrolment methods
        1. https://docs.moodle.org/311/en/Enable_guest_access
      4. Create a course with a student enrolled
      5. Enable guest enrolment for the course
      6. Create an activity on the site home page

      Testing

      1. Log in as an admin
      2. Confirm you see the following options in the primary navigation:
        1. Home
        2. Dashboard
        3. My courses
        4. Site admin
      3. Go to the ‘Home’ page
      4. Confirm Home is highlighted in the primary navigation
      5. Add a navigation block if not added
      6. Click the cog icon on the navigation block
      7. Go to the ‘Configure’ page of the block
      8. Confirm Home is highlighted in the primary navigation
      9. Go to the activity on the site page
      10. Confirm the Home page is highlighted
      11. Via the side drawer,
        1. Click on the following links:
          1. Calendar
          2. Private files
          3. Content bank
        2. Confirm in each of the above, ‘Home’ is highlighted in primary navigation
      12. Via the user menu
        1. Click on the following options:
          1. Profile
          2. Grades
          3. Messages
          4. Preferences
        2. Confirm in each of the above, ‘Home’ is highlighted in primary navigation
      13. Go to the ‘Dashboard’ page
      14. Confirm Dashboard is highlighted in the primary navigation
      15. Click on the cog icon on the myoverview block
      16. Go to the ‘Configure’ page of the block
      17. Confirm Dashboard is highlighted in the primary navigation
      18. Go the course created previously
      19. Confirm My courses is highlighted in the primary navigation
      20. Go to the glossary within the course
      21. Confirm My courses is highlighted in the primary navigation
      22. Click on the ‘Site administration’ option
      23. Confirm ‘Site administration’ is highlighted in the primary navigation
      24. Click on ‘Plugins > Activity modules > Manage activities’
      25. Confirm ‘Site administration’ is highlighted in the primary navigation
      26. Log out
      27. Log in as student
      28. Confirm you see the following in the primary navigation:
        1. Home
        2. Dashboard
        3. My courses
      29. Repeat steps #3-#21
      30. Logout
      31. Confirm ‘Home’ is highlighted in the primary navigation
      32. Log in as a guest user
      33. Confirm you see Home, My courses in the primary navigation
      34. Go to the course created
      35. Confirm ‘My courses’ is marked as active
      36. Go to the glossary activity in the course
      37. Confirm ‘My courses’ is marked as active

      Common pages test

      1. Log in as an admin
      2. Go the 'course/index.php' page
      3. Confirm 'Site Admin' is highlighted
      4. Click on any of the categories listed
      5. Confirm 'Site Admin' is highlighted
      6. Go to any of the tabs listed
      7. Confirm 'Site Admin' is highlighted
      8. Log in as the student
      9. Go the 'course/index.php' page
      10. Confirm 'Home' is highlighted
      11. Click on any of the categories listed
      12. Confirm 'Home' is highlighted
      13. Go to any of the tabs listed
      14. Confirm 'Home' is highlighted.

      Secondarynav test

      1. Log in as admin
      2. Go to the site admin
      3. Go to Plugins > Activity Modules > Feedback comments
      4. Confirm the "Plugins" tab is marked as active
      Show
      Confirm behat test passes Prerequisites: Login as an admin Create a feedback activity on the site home Enable guest access and enrolment methods https://docs.moodle.org/311/en/Enable_guest_access Create a course with a student enrolled Enable guest enrolment for the course Create an activity on the site home page Testing Log in as an admin Confirm you see the following options in the primary navigation: Home Dashboard My courses Site admin Go to the ‘Home’ page Confirm Home is highlighted in the primary navigation Add a navigation block if not added Click the cog icon on the navigation block Go to the ‘Configure’ page of the block Confirm Home is highlighted in the primary navigation Go to the activity on the site page Confirm the Home page is highlighted Via the side drawer, Click on the following links: Calendar Private files Content bank Confirm in each of the above, ‘Home’ is highlighted in primary navigation Via the user menu Click on the following options: Profile Grades Messages Preferences Confirm in each of the above, ‘Home’ is highlighted in primary navigation Go to the ‘Dashboard’ page Confirm Dashboard is highlighted in the primary navigation Click on the cog icon on the myoverview block Go to the ‘Configure’ page of the block Confirm Dashboard is highlighted in the primary navigation Go the course created previously Confirm My courses is highlighted in the primary navigation Go to the glossary within the course Confirm My courses is highlighted in the primary navigation Click on the ‘Site administration’ option Confirm ‘Site administration’ is highlighted in the primary navigation Click on ‘Plugins > Activity modules > Manage activities’ Confirm ‘Site administration’ is highlighted in the primary navigation Log out Log in as student Confirm you see the following in the primary navigation: Home Dashboard My courses Repeat steps #3-#21 Logout Confirm ‘Home’ is highlighted in the primary navigation Log in as a guest user Confirm you see Home, My courses in the primary navigation Go to the course created Confirm ‘My courses’ is marked as active Go to the glossary activity in the course Confirm ‘My courses’ is marked as active Common pages test Log in as an admin Go the 'course/index.php' page Confirm 'Site Admin' is highlighted Click on any of the categories listed Confirm 'Site Admin' is highlighted Go to any of the tabs listed Confirm 'Site Admin' is highlighted Log in as the student Go the 'course/index.php' page Confirm 'Home' is highlighted Click on any of the categories listed Confirm 'Home' is highlighted Go to any of the tabs listed Confirm 'Home' is highlighted. Secondarynav test Log in as admin Go to the site admin Go to Plugins > Activity Modules > Feedback comments Confirm the "Plugins" tab is marked as active
    • Story Points:
      3
    • Sprint:
      Navigation push 7, Navigation push 8

      Description

      Scenario 1:

      At all times when navigating around the site, a primary navigation tab should be highlighted.

      We created MDL-72396 to help with this, but if it looks like we need to add that command to every page, then we need to find a different solution.

      Approach (simple, no frills):

      • In a course context, highlight "My courses"
      • Home and Dashboard maps directly
      • Everything else is "Site admin"

      Also make sure that primary navigation text does not change based on default homepage

      Scenario 2:

      Specifically in site admin, we need to ensure that when on deep nested links, the secondary navigation is properly highlighted

      Additional updates

      Remove mycourses link in pages for unauthenticated and guest users

        Attachments

        1. MDL-72816_Admin1_Test Passed.png
          MDL-72816_Admin1_Test Passed.png
          420 kB
        2. MDL-72816_Admin2_Test Passed.png
          MDL-72816_Admin2_Test Passed.png
          316 kB
        3. MDL-72816_Common Pages Test_Test Passed.png
          MDL-72816_Common Pages Test_Test Passed.png
          202 kB
        4. MDL-72816_Guest_Test Passed.png
          MDL-72816_Guest_Test Passed.png
          106 kB
        5. MDL-72816_Student_Test Passed.png
          MDL-72816_Student_Test Passed.png
          661 kB
        6. sample.patch
          3 kB
        7. sample-1.patch
          0.7 kB
        8. Secondarynav test_Test Passed.PNG
          Secondarynav test_Test Passed.PNG
          72 kB

          Issue Links

            Activity

              People

              Assignee:
              peterdias Peter Dias
              Reporter:
              abgreeve Adrian Greeve
              Peer reviewer:
              Mathew May Mathew May
              Integrator:
              Ilya Tregubov Ilya Tregubov
              Tester:
              Gladys Basiana Gladys Basiana
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 0 minutes
                  0m
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 day, 6 hours, 20 minutes
                  1d 6h 20m