Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-72847

Add $CFG->session_redis_acquire_lock_timeout_warn

    XMLWordPrintable

Details

    • Improvement
    • Status: Open
    • Minor
    • Resolution: Unresolved
    • Future Dev
    • None
    • Authentication, Performance
    • None

    Description

      We are on a mission to gradually ratchet this timeout down to something very short, basically there should not be any reason for code to hold a session lock for more than say 1 second in an ideal world. So in that scenario nothing should every wait for more than say 2 seconds to gain the lock.

      $CFG->session_redis_acquire_lock_timeout

      The current code throws an exception and logs an error when this timeout is hit, but generally this is rare in prod because we've tuned it just high enough to not happen much. But we'd like a way to warn and emit errors at some lower threshold to aid in hunting down all the dodgy code which is holding onto locks for longer than it should.

      Attachments

        Activity

          People

            Unassigned Unassigned
            brendanheywood Brendan Heywood
            Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Matteo Scaramuccia, Andrew Lyons, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Stevani Andolo
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated: