Moodle
  1. Moodle
  2. MDL-7287

Lesson uses an HTTP include when a normal include would do

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.7, 1.8
    • Fix Version/s: 1.7, 1.8
    • Component/s: Lesson
    • Labels:
      None
    • Affected Branches:
      MOODLE_17_STABLE, MOODLE_18_STABLE
    • Fixed Branches:
      MOODLE_17_STABLE, MOODLE_18_STABLE
    • Rank:
      27845

      Description

      lesson/continue.php includes continue.html using an HTTP include, but it's in the same directory! why do that? Also on our server it doesn't work because of the load-balancing setup (complicated, but basically they can't make requests from themselves using the public URL). I'm changing it to a regular include.

          1. Eclipse Workspace Patch 1.0
            #P core-moodle-stable
            Index: mod/lesson/action/continue.php
            ===================================================================
            RCS file: /cvsroot/moodle/moodle/mod/lesson/action/continue.php,v
            retrieving revision 1.33
            diff -u -r1.33 continue.php
          • mod/lesson/action/continue.php 30 Sep 2006 19:49:41 -0000 1.33
            +++ mod/lesson/action/continue.php 30 Oct 2006 10:44:32 -0000
            @@ -773,5 +773,5 @@

      lesson_print_header($cm, $course, $lesson, 'navigation');

      • include($CFG->wwwroot.'/mod/lesson/action/continue.html');
        + include(dirname(_FILE_).'/continue.html');
        ?>

        Activity

        Hide
        Sam Marshall added a comment -

        Fix (as above) checked in to MOODLE_17_STABLE and merged to HEAD.

        Show
        Sam Marshall added a comment - Fix (as above) checked in to MOODLE_17_STABLE and merged to HEAD.

          People

          • Assignee:
            Sam Marshall
            Reporter:
            Sam Marshall
            Tester:
            Nobody
            Participants:
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: