Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-72907

Fix repository::enable_plugin function to be able to enable repository plugins

XMLWordPrintable

    • MOODLE_400_STABLE
    • MOODLE_400_STABLE
    • MDL-72907-master
    • Hide
      • Changes covered by unit tests.

      Manual testing (confirm everything still works OK)

      1. As admin go to "Site administration > Plugins > Manage repositories".
      2. Set the "Content bank" repository to "Enabled but hidden". 
      3. Check the page is reloaded and the "Content bank" repository now is set to the "Enabled but hidden" option.
      4. Set it back to "Enabled and visible"
      5. Check the page is reloaded and the "Content bank" repository now is set to the "Enabled and visible" option.
      6. Set the "Content bank" repository to "Disabled".
      7. Click on "Continue" button.
      8. Check the "Content bank" repository now is set to the "Disabled" option.
      9. Set the "Content bank" repository to "Enabled and visible".
      10. Click on "Save" button.
      11. Check the "Content bank" repository now is set to the "Enabled and visible" option.
      12. Set the "Content bank" repository to "Disabled".
      13. Click on "Continue" button.
      14. Check the "Content bank" repository now is set to the "Disabled" option.
      15. Set the "Content bank" repository to "Enabled but hidden".
      16. Click on "Save" button.
      17. Check the "Content bank" repository now is set to the "Enabled but hidden" option.
      18. Go to "Site administration > Reports > Config changes".
      19. Check last changes are displayed in the log.
      Show
      Changes covered by unit tests. Manual testing (confirm everything still works OK) As admin go to "Site administration > Plugins > Manage repositories". Set the "Content bank" repository to "Enabled but hidden".  Check  the page is reloaded and the "Content bank" repository now is set to the "Enabled but hidden" option. Set it back to "Enabled and visible" Check  the page is reloaded and the "Content bank" repository now is set to the "Enabled and visible" option. Set the "Content bank" repository to "Disabled". Click on "Continue" button. Check the "Content bank" repository now is set to the "Disabled" option. Set the "Content bank" repository to "Enabled and visible". Click on "Save" button. Check the "Content bank" repository now is set to the "Enabled and visible" option. Set the "Content bank" repository to "Disabled". Click on "Continue" button. Check the "Content bank" repository now is set to the "Disabled" option. Set the "Content bank" repository to "Enabled but hidden". Click on "Save" button. Check the "Content bank" repository now is set to the "Enabled but hidden" option. Go to "Site administration > Reports > Config changes". Check  last changes are displayed in the log.
    • Moppies Kanban

      enable_plugin function for repositories created in MDL-72720 is working when disabling a repository plugin, but not when enabling a disabled one. The reason why is not working is because is checking that the repository exists in 'mdl_repository' table, but only active repositories could be found in that table.

      The reason why was not implemented in MDL-72720 is because for some cases we need more information/settings to enable a plugin, so it's not easy to validate if the plugin could be enabled or not.

      Found working on MDL-72769, this will be an important bug for MDL-72112. Taking into consideration that new installations will follow Lite settings, with some repositories disabled by default, if the admin tries to change to 'Full Moodle' preset, those repositories won't be enabled and the admin would need to enable them manually.

        1. MDL-72907_Test Passed.png
          163 kB
          Gladys Basiana

            amaia Amaia Anabitarte
            amaia Amaia Anabitarte
            Carlos Escobedo Carlos Escobedo
            Shamim Rezaie Shamim Rezaie
            Gladys Basiana Gladys Basiana
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 day, 6 hours, 45 minutes
                1d 6h 45m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.