[MDL-72913] Require in courses' externallib should be absolute - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.9.10, 3.10.7
Fix Version/s: 3.9.11, 3.10.8
Component/s: Course
Labels:

Affected Branches:
MOODLE_310_STABLE, MOODLE_39_STABLE
Fixed Branches:
MOODLE_310_STABLE, MOODLE_39_STABLE
Pull from Repository:
git://github.com/NoelDeMartin/moodle.git
Pull 3.9 Branch:
~~MDL-72913~~-39
Pull 3.9 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_39_STABLE...NoelDeMartin:MDL-72913-39
Testing Instructions:
Hide

As an admin, enable "Mobile services": Site administration ► Mobile app ► Mobile settings

Create a Token in the mobile app service

Click on Site administration ► Plugins ► Web services ► Manage tokens

Open the console and execute this new curl request, replacing wstoken with the token you just created and the site url with yours.

curl 'http://YOUR_SITE/webservice/rest/server.php?moodlewsrestformat=json' --data 'wsfunction=core_course_get_recent_courses&wstoken=WS_TOKEN'

Confirm that you get an array with the courses. This could be an empty array as well, before this fix you would get an error saying "Call to undefined function course_get_recent_courses()".
Show
As an admin, enable "Mobile services": Site administration ► Mobile app ► Mobile settings Create a Token in the mobile app service Click on Site administration ► Plugins ► Web services ► Manage tokens Open the console and execute this new curl request, replacing wstoken with the token you just created and the site url with yours. curl 'http://YOUR_SITE/webservice/rest/server.php?moodlewsrestformat=json' --data 'wsfunction=core_course_get_recent_courses&wstoken=WS_TOKEN' Confirm that you get an array with the courses. This could be an empty array as well, before this fix you would get an error saying " Call to undefined function course_get_recent_courses() ".

Description

The require statement in course/externallib.php is relative and this can cause some errors when webservices are called. This seems to have been fixed in 311 and master, but the issue still remains for 310 and 39 stables.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

MDL-72913_Test Passed.png
84 kB
27/Oct/21 2:02 PM

Issue Links

duplicates

MDL-69944 Call to undefined function course_get_recent_courses()

Closed

Activity

People

Assignee:: Noel De Martin

Reporter:: Noel De Martin

Peer reviewer:: Carlos Escobedo

Integrator:: Eloy Lafuente (stronk7)

Tester:: Gladys Basiana

Participants:: Carlos Escobedo, CiBoT, Eloy Lafuente (stronk7), Gladys Basiana, Noel De Martin

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Laurent David, Mikel Martín Corrales, Sabina Abellan, Sara Arjona (@sarjona)

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 26/Oct/21 2:50 PM

Updated:: 17/Nov/21 6:43 PM

Resolved:: 29/Oct/21 11:34 PM

Fix Release Date:: 8/Nov/21

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

55m