[MDL-72924] Check manager incorrectly instantiates plugin supplied performance checks - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.10.7, 3.11.3, 4.0
Fix Version/s: 3.10.8, 3.11.4
Component/s: Reports
Labels:
- CatalystIT
- ci
- partner

Affected Branches:
MOODLE_310_STABLE, MOODLE_311_STABLE, MOODLE_400_STABLE
Fixed Branches:
MOODLE_310_STABLE, MOODLE_311_STABLE
Pull from Repository:
https://github.com/keevan/moodle/
Pull 3.11 Branch:
~~MDL-72924~~-fix-component-initialisation-for-performance-checks-MOODLE_311_STABLE
Pull 3.11 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_311_STABLE...keevan:MDL-72924-fix-component-initialisation-for-performance-checks-MOODLE_311_STABLE
Pull Master Branch:
~~MDL-72924~~-fix-component-initialisation-for-performance-checks
Pull Master Diff URL:
https://github.com/moodle/moodle/compare/master...keevan:MDL-72924-fix-component-initialisation-for-performance-checks
Testing Instructions:
Hide

1) Update an existing status check, to the type of performance located here: /admin/tool/task/lib.php which is demonstrated in the diff below.

(This changes part of the function name from status to performance)

-function tool_task_status_checks() : array {

+function tool_task_performance_checks() : array {

2) Purge the caches

3) Go to /report/performance/index.php and confirm you do not see any errors

4) Confirm you do see the 'Cron running' check in the table (it's status doesn't matter).
Show
1) Update an existing status check, to the type of performance located here: /admin/tool/task/lib.php which is demonstrated in the diff below. (This changes part of the function name from status to performance) -function tool_task_status_checks() : array { +function tool_task_performance_checks() : array { 2) Purge the caches 3) Go to /report/performance/index.php and confirm you do not see any errors 4) Confirm you do see the 'Cron running' check in the table (it's status doesn't matter).

Description

Attempting to define a third party performance check in a plugin leads to a coding error when attempting to view the Performance check report.

Exception - Cannot access protected property tool_xxx\check\enabled::$component

Stack trace:

line 82 of /lib/classes/check/manager.php: Error thrown
line 56 of /lib/classes/check/manager.php: call to core\check\manager::get_performance_checks()
line 72 of /lib/classes/check/table.php: call to core\check\manager::get_checks()
line 35 of /report/performance/index.php: call to core\check\table->__construct()

The manager attempts to directly set $check->component, whereas it is correctly accessed using the set_component() method for status and security checks

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

MDL-72924_master.png
148 kB
29/Oct/21 11:26 AM
MDL-72924_v310.png
130 kB
29/Oct/21 11:26 AM
MDL-72924_v311.png
130 kB
29/Oct/21 11:26 AM

Activity

People

Assignee:: Kevin Pham

Reporter:: Peter Burnett

Peer reviewer:: Brendan Heywood

Integrator:: Shamim Rezaie

Tester:: Angelia Dela Cruz

Participants:: Angelia Dela Cruz, Brendan Heywood, CiBoT, Kevin Pham, Peter Burnett, Shamim Rezaie

Component watchers:: Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Sujith Haridasan

Votes:: 1 Vote for this issue

Watchers:: 6 Start watching this issue

Dates

Created:: 27/Oct/21 11:40 AM

Updated:: 29/Oct/21 11:34 PM

Resolved:: 29/Oct/21 11:34 PM

Fix Release Date:: 8/Nov/21

Time Tracking

Estimated:

Remaining:

Logged:

15m