Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-72963

Inplace editable doesn't work properly for course activity names in Firefox after MDL-71664

    XMLWordPrintable

Details

    • MOODLE_400_STABLE
    • MOODLE_400_STABLE
    • MDL-72963-master
    • Hide

      This test should be executed in both chrome and firefox

      1. Create a course in topics format with at least 1 section and an activity (any kind)
      2. Turn editing on
      3. Click the pen icon next to the activity
        1. Check the inplace editable appears with all the name selected
        2. Click in the middle of the text
          1. Check the text deselect and the cursor move to the click position
        3. Type some characters and press enter key
          1. Check the element is renamed
        4. Drag the activity to another position
          1. Check the element can be moved by dragging
      4. Click the pen icon next to the activity again
        1. Type some text to replace the content and then Press esc key
          1. Check the inplace editable disappears
          2. Check the element has not been renamed
          3. Check the element can be moved by dragging
      5. Click the pen icon next to the activity one more time
        1. Type some text to replace the content and then click on another part of the page
          1. Check the inplace editable disappears
          2. Check the element can be moved by dragging
          3. Check the element name does not change
      6. Repeat steps 3, 4 and 5 but with the section name and do the same checks
      Show
      This test should be executed in both chrome and firefox Create a course in topics format with at least 1 section and an activity (any kind) Turn editing on Click the pen icon next to the activity Check the inplace editable appears with all the name selected Click in the middle of the text Check the text deselect and the cursor move to the click position Type some characters and press enter key Check the element is renamed Drag the activity to another position Check the element can be moved by dragging Click the pen icon next to the activity again Type some text to replace the content and then Press esc key Check the inplace editable disappears Check the element has not been renamed Check the element can be moved by dragging Click the pen icon next to the activity one more time Type some text to replace the content and then click on another part of the page Check the inplace editable disappears Check the element can be moved by dragging Check the element name does not change Repeat steps 3, 4 and 5 but with the section name and do the same checks
    • Moppies Kanban

    Description

      Regression from MDL-71664, as kindly confirmed by dobedobedoh with a bisect. Affects the mouse deselection of text in the inplace editable control on course activities.

      Basically, to replicate:

      1. Fire up a master site
      2. Create a course, add an activity (anything) and turn editing on
      3. Using the inplace editable control with the mouse try to edit the name of the activity.
      4. Notice when editing mode begins, you see the entire text of the name selected.
      5. Try to click in the selection to edit a particular point (i.e. to get a cursor)
        • Expected: The selection is lost and we see a cursor for editing the text
        • Actual: Nothing happens and the selection is still present.

      E.g. Clicking the selected text in the screen below does nothing in Firefox. Chrome does work.

      Workaround: Use keyboard left/right to start the edit.

      Attachments

        Issue Links

          Activity

            People

              tusefomal Ferran Recio
              jaked Jake Dallimore
              Amaia Anabitarte Amaia Anabitarte
              Shamim Rezaie Shamim Rezaie
              Gladys Basiana Gladys Basiana
              Amaia Anabitarte, Bas Brands, Carlos Escobedo, Laurent David, Raquel Ortega, Sabina Abellan, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                19/Apr/22

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 hours, 5 minutes
                  2h 5m