[MDL-72982] Data request email breaks organisation signature - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.9.10, 3.11.4
Fix Version/s: 3.11.5
Component/s: Privacy
Labels:

Affected Branches:
MOODLE_311_STABLE, MOODLE_39_STABLE
Fixed Branches:
MOODLE_311_STABLE
Pull from Repository:
https://github.com/junpataleta/moodle.git
Pull 3.11 Branch:
~~MDL-72982~~-311
Pull 3.11 Diff URL:
https://github.com/junpataleta/moodle/compare/e1ad263f90...MDL-72982-311
Pull Master Branch:
~~MDL-72982~~-master
Pull Master Diff URL:
https://github.com/junpataleta/moodle/compare/d135a1200a...MDL-72982-master

Testing Instructions:

Hide

Setup

Outgoing email setup (e.g. using mailcatcher/mailhog)
"Contact the privacy officer" admin setting enabled (Under "Site administration / Privacy and policies / Privacy settings")

Test

Go to your user profile
Contact the privacy officer or make a data export request
Check the data request email
Inspect the email's html.

Edit the <body> attribute of the email and enter the following markup right after the <div> tag.

<table>

    <tbody>

        <tr>

            <th>Hello!</th>

            <td>This is my custom signature</td>

        </tr>

    </tbody>

</table>

e.g.

<body>

  <div>

     <p>Dear user,</p>

...

   </div>

<table>

    <tbody>

        <tr>

            <th>Hello!</th>

            <td>This is my custom signature</td>

        </tr>

    </tbody>

</table>

Confirm that the "This is my signature" table is displayed without borders.

Show

Setup Outgoing email setup (e.g. using mailcatcher/mailhog) " Contact the privacy officer " admin setting enabled (Under " Site administration / Privacy and policies / Privacy settings ") Test Go to your user profile Contact the privacy officer or make a data export request Check the data request email Inspect the email's html. Edit the <body> attribute of the email and enter the following markup right after the <div> tag. <table> <tbody> <tr> <th>Hello!</th> <td>This is my custom signature</td> </tr> </tbody> </table> e.g. <body> <div> <p>Dear user,</p> ... </div> <table> <tbody> <tr> <th>Hello!</th> <td>This is my custom signature</td> </tr> </tbody> </table> Confirm that the " This is my signature " table is displayed without borders.

Description

Due to the below code in the data_request_mail.mustache, the organization signature breaks .

{ border: 1px solid black; padding: 0.5em; }

</style>

How to reproduce

You need:

To Configure a outgoing mail in Moodle with an emailadress that uses an organization signature.
Have a privacy officer account with a valid emailadress.
Set up Privacy settings.

**Test:

Login as a student
Ask to remove your personal details.
As a Privacy officer check if you now see your organizaton signature correctly in the email.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

kader_1.png
58 kB
02/Nov/21 10:52 PM
MDL-72982_master.png
104 kB
12/Nov/21 9:02 AM
MDL-72982_v311.png
86 kB
12/Nov/21 9:02 AM
proof_fix_M39.png
36 kB
10/Nov/21 5:56 PM

Activity

People

Assignee:: Luuk Verhoeven

Reporter:: Gemma Lesterhuis

Peer reviewer:: Dongsheng Cai

Integrator:: Jun Pataleta

Tester:: Angelia Dela Cruz

Participants:: Angelia Dela Cruz, CiBoT, Dongsheng Cai, Eloy Lafuente (stronk7), Gemma Lesterhuis, Jun Pataleta, Luuk Verhoeven

Component watchers:: Andrew Lyons, Adrian Greeve, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo

Votes:: 0 Vote for this issue

Watchers:: 6 Start watching this issue

Dates

Created:: 02/Nov/21 10:51 PM

Updated:: 12/Jan/22 6:32 PM

Resolved:: 12/Nov/21 9:03 PM

Fix Release Date:: 17/Jan/22

Time Tracking

Estimated:

Remaining:

Logged:

1h 35m