Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-72982

Data request email breaks organisation signature

    XMLWordPrintable

Details

    • MOODLE_311_STABLE, MOODLE_39_STABLE
    • MOODLE_311_STABLE
    • MDL-72982-311
    • MDL-72982-master
    • Hide
      Setup
      1. Outgoing email setup (e.g. using mailcatcher/mailhog)
      2. "Contact the privacy officer" admin setting enabled (Under "Site administration / Privacy and policies / Privacy settings")
      Test
      1. Go to your user profile
      2. Contact the privacy officer or make a data export request
      3. Check the data request email
      4. Inspect the email's html.
      5. Edit the <body> attribute of the email and enter the following markup right after the <div> tag.

        <table>
            <tbody>
                <tr>
                    <th>Hello!</th>
                    <td>This is my custom signature</td>
                </tr>
            </tbody>
        </table>
        

        e.g.

        <body>
          <div>
             <p>Dear user,</p>
             ...
           </div>
        <table>
            <tbody>
                <tr>
                    <th>Hello!</th>
                    <td>This is my custom signature</td>
                </tr>
            </tbody>
        </table>
        

      6. Confirm that the "This is my signature" table is displayed without borders.
      Show
      Setup Outgoing email setup (e.g. using mailcatcher/mailhog) " Contact the privacy officer " admin setting enabled (Under " Site administration / Privacy and policies / Privacy settings ") Test Go to your user profile Contact the privacy officer or make a data export request Check the data request email Inspect the email's html. Edit the <body> attribute of the email and enter the following markup right after the <div> tag. <table> <tbody> <tr> <th>Hello!</th> <td>This is my custom signature</td> </tr> </tbody> </table> e.g. <body> <div> <p>Dear user,</p> ... </div> <table> <tbody> <tr> <th>Hello!</th> <td>This is my custom signature</td> </tr> </tbody> </table> Confirm that the " This is my signature " table is displayed without borders.

    Description

      Due to the below code in the data_request_mail.mustache, the organization signature breaks . 

      <style>
      table, th, td

      { border: 1px solid black; padding: 0.5em; }

      </style>

       

      How to reproduce

      You need: 

      1. To Configure a outgoing mail in Moodle with an emailadress that uses an organization signature. 
      2. Have a privacy officer account with a valid emailadress.
      3. Set up Privacy settings. 

      **Test: 

      1. Login as a student
      2. Ask to remove your personal details.
      3. As a Privacy officer check if you now see your organizaton signature correctly in the email. 

      Attachments

        1. kader_1.png
          kader_1.png
          58 kB
        2. MDL-72982_master.png
          MDL-72982_master.png
          104 kB
        3. MDL-72982_v311.png
          MDL-72982_v311.png
          86 kB
        4. proof_fix_M39.png
          proof_fix_M39.png
          36 kB

        Activity

          People

            mfreak Luuk Verhoeven
            gemguardian Gemma Lesterhuis
            Dongsheng Cai Dongsheng Cai
            Jun Pataleta Jun Pataleta
            Angelia Dela Cruz Angelia Dela Cruz
            Andrew Lyons, Adrian Greeve, David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              17/Jan/22

              Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 35 minutes
                1h 35m