[MDL-73004] tool_brickfield unit tests fail if you install qtype_coderunner - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 3.11.3, 4.0
Fix Version/s: 3.11.5
Component/s: Accessibility toolkit
Labels:
- ci

Affected Branches:
MOODLE_311_STABLE, MOODLE_400_STABLE
Fixed Branches:
MOODLE_311_STABLE
Pull from Repository:
https://github.com/brickfield/moodle
Pull 3.11 Branch:
~~MDL-73004~~-311_access_unit_tests
Pull 3.11 Diff URL:
https://github.com/brickfield/moodle/commit/29bfe17f2c5b162fc0810f6389a9e58789a4aa8a
Pull Master Branch:
~~MDL-73004~~-master_access_unit_tests
Pull Master Diff URL:
https://github.com/brickfield/moodle/commit/23cb59bd85afd0006d7b313397960e182111f500
Testing Instructions:
Hide

Download, unzip and put qbehaviour_adaptive_adapted_for_coderunner in place (question/behaviour/adapted_for_coderunner directory).

Download, unzip and put qtype_coderunner in place (question/type/coderunner directory).

Init phpunit

php admin/tool/phpunit/cli/init.php

Run the tool_brickfield unit tests

vendor/bin/phpunit --testsuite tool_brickfield_testsuite

Verify that the unit tests pass.
Show
Download, unzip and put qbehaviour_adaptive_adapted_for_coderunner in place ( question/behaviour/adapted_for_coderunner directory). Download, unzip and put qtype_coderunner in place ( question/type/coderunner directory). Init phpunit php admin/tool/phpunit/cli/init.php Run the tool_brickfield unit tests vendor/bin/phpunit --testsuite tool_brickfield_testsuite Verify that the unit tests pass.

Description

Steps to reproduce

Install qtype_coderunner from the moodle plugins DB.
Run the tool_brickfield unit tests.

Expected results: there pass.
Actual result: there are failures.

E.g.

tool_brickfield\area_test::test_questiontext
Failed asserting that actual size 23 matches expected size 4.

/var/www/html/20211025_020001_23_tt_overnight_full/admin/tool/brickfield/tests/area_test.php:104
/var/www/html/20211025_020001_23_tt_overnight_full/lib/phpunit/classes/advanced_testcase.php:80

Attachments

Issue Links

has a non-specific relationship to

MDL-66903 New APIs for generators, behat stuff... or no. And autoloading for them

Open

has been marked as being related by

MDL-62483 Should be harder to write fragile unit tests that make unwarranted assumptions about a new Moodle install

Open

Activity

People

Assignee:: Mike Churchward

Reporter:: Tim Hunt

Peer reviewer:: Tim Hunt

Integrator:: Eloy Lafuente (stronk7)

Tester:: Eloy Lafuente (stronk7)

Participants:: CiBoT, Eloy Lafuente (stronk7), Mike Churchward, Tim Hunt

Component watchers:: Mike Churchward, Karen Holland

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 05/Nov/21 4:33 AM

Updated:: 12/Apr/22 6:08 PM

Resolved:: 14/Jan/22 7:26 PM

Fix Release Date:: 17/Jan/22

Time Tracking

Estimated:

Not Specified

Remaining:

Logged: