Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-73039

Double encoding of site/course name in course download

    XMLWordPrintable

Details

    • MOODLE_311_STABLE
    • MOODLE_311_STABLE
    • MDL-73039-311
    • Hide
      1. Log in as admin
      2. Navigate to Site home > Site home settings in 4.0 site administration or Front page > Front page settings in 3.11 site administration
      3. Set Full site name to: "This & That" and save changes
      4. Navigate to Courses > Download course content in site administration
      5. Enable Download course content feature available and save changes
      6. Create a new course:
        • Course full name: "Apples & Oranges"
        • Enable download course content: Yes
      7. From the course page, select More > Download course content > Download on 4.0 or Actions cog menu > Download course content > Download on 3.11
      8. Extract downloaded file to directory and open index.html from it's root
      9. Confirm the page title (in the browser tab and/or title bar) is the following, i.e. no double encoding: 

        This & That - Apples & Oranges

      10. Confirm the page heading is the following, i.e. no double encoding: 

        Apples & Oranges

      Show
      Log in as admin Navigate to Site home > Site home settings  in 4.0 site administration or Front page > Front page settings in 3.11 site administration Set Full site name to: "This & That" and save changes Navigate to Courses > Download course content in site administration Enable Download course content feature available and save changes Create a new course: Course full name: "Apples & Oranges" Enable download course content: Yes From the course page, select More > Download course content > Download on 4.0 or Actions cog menu > Download course content > Download on 3.11 Extract downloaded file to directory and open index.html from it's root Confirm the page title (in the browser tab and/or title bar) is the following, i.e. no double encoding: This & That - Apples & Oranges Confirm the page heading is the following, i.e. no double encoding: Apples & Oranges

    Description

      Site & course names are double encoded when included as part of course download:

      Site name & course name are already formatted/cleaned before being passed to templates used for course download functionality: https://github.com/moodle/moodle/blob/d135a1200a87a62cad7afa2e51889b845f72e4cb/lib/classes/content/export/zipwriter.php#L252-L259

      Attachments

        Activity

          People

            pholden Paul Holden
            pholden Paul Holden
            Amaia Anabitarte Amaia Anabitarte
            Victor Déniz Falcón Victor Déniz Falcón
            Gladys Basiana Gladys Basiana
            Amaia Anabitarte, Carlos Escobedo, Laurent David, Mikel Martín Corrales, Sabina Abellan, Sara Arjona (@sarjona)
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              17/Jan/22

              Time Tracking

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 4 days, 1 hour, 15 minutes
                4d 1h 15m