Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-73144

Allow use of dartsass for scss compilation

XMLWordPrintable

    • MOODLE_400_STABLE, MOODLE_402_STABLE
    • MOODLE_402_STABLE
    • MDL-73144/402
    • Hide

      Developer testing

      1. npm install
      2. run grunt - confirm no files are changed
      3. run behat

      Testing scenario 1: Test if all theme CSS and Font awesome icons look ok

      1. Login as Admin
      2. Purge all caches
      3. Verify CSS styling did not change visually
      4. Verify Fontawesome icons are rendered correctly
      5. Verify the JS functionality works for: Alerts (dismiss), Buttons (remember state), Carousel (slide), Dropdown (show menu), Popover (show popover). Tooltips (show tooltip)
      6. Access to your apache logs (they use to be placed at /var/log/apache2/error.log) and check that there are no sass parse errors there.

      Testing scenario 2: Check logs

      1. Login as Admin
      2. Navigate to Site Administration -> Development -> Debugging
      3. Choose Developer.. at Debug messages
      4. Tick the Display debug messages checkbox
      5. Open a console showing your web server / PHP log files (they use to be placed at /var/log/apache2/access.log and /var/log/apache2/error.log)
      6. Navigate to Site Administration -> Development -> Purge Caches
      7. Navigate to the Site Homepage
      8. Wait for the page to load and rebuild caches
      9. Check log files (access.log and error.log) doesn't contain errors.

       

      Show
      Developer testing npm install run grunt - confirm no files are changed run behat Testing scenario 1: Test if all theme CSS and Font awesome icons look ok Login as Admin Purge all caches Verify CSS styling did not change visually Verify Fontawesome icons are rendered correctly Verify the JS functionality works for: Alerts (dismiss), Buttons (remember state), Carousel (slide), Dropdown (show menu), Popover (show popover). Tooltips (show tooltip) Access to your apache logs (they use to be placed at /var/log/apache2/error.log) and check that there are no sass parse errors there. Testing scenario 2: Check logs Login as Admin Navigate to Site Administration -> Development -> Debugging Choose Developer.. at Debug messages Tick the Display debug messages checkbox Open a console showing your web server / PHP log files (they use to be placed at /var/log/apache2/access.log and /var/log/apache2/error.log) Navigate to Site Administration -> Development -> Purge Caches Navigate to the Site Homepage Wait for the page to load and rebuild caches Check  log files (access.log and error.log) doesn't contain errors.  

      sassc has been deprecated in favour of dartsass
      Deprecation notice: https://github.com/sass/sassc
      dartsass: https://sass-lang.com/dart-sass

      Arguments differ, so assuming the build is compatible otherwise, we need to add support for dart-sass.

      Required changes:

      1. Bootstrap v4.6.2 - replaces "/" division with "*" and adds divide function
      2. Replace "/" with "*" and divide function in Moodle sass

            skodak Petr Skoda
            dobedobedoh Andrew Lyons
            Andrew Lyons Andrew Lyons
            Jun Pataleta Jun Pataleta
            Jun Pataleta Jun Pataleta
            Votes:
            2 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 hours, 41 minutes
                2h 41m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.