Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-73166

Fix action links accessibility in system reports

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 4.0
    • 4.0
    • Report builder
    • MOODLE_400_STABLE
    • MOODLE_400_STABLE
    • Hide

      Setup

      1. Install Wave extension
      2. Navigate to Reports > Report builder > Custom reports in site administration
      3. Press "New report" button
      4. Set any report name.
      5. Set Report source to "Users"
      6. Ensure "Include default setup" is checked
      7. Press Save

      Test no regressions were added

      1. Navigate to Reports > Report builder > Custom reports in site administration
      2. Confirm that all action links work correctly
        1. Edit report content
        2. Edit report details
        3. View report
        4. Delete report
      3. Navigate to Server > Task logs
      4. Confirm that all action links work correctly
        1. View
        2. Download

      Test accessibility issues are fixed

      1. Navigate to Reports > Report builder > Custom reports in site administration
      2. Use WAVE extension to scan the page
      3. Cofirm that "Empty link" errors don not appear in the report action links
      Show
      Setup Install Wave extension Navigate to Reports > Report builder > Custom reports in site administration Press "New report" button Set any report name. Set Report source to "Users" Ensure "Include default setup" is checked Press Save Test no regressions were added Navigate to Reports > Report builder > Custom reports in site administration Confirm that all action links work correctly Edit report content Edit report details View report Delete report Navigate to Server > Task logs Confirm that all action links work correctly View Download Test accessibility issues are fixed Navigate to Reports > Report builder > Custom reports in site administration Use WAVE extension to scan the page Cofirm that "Empty link" errors don not appear in the report action links

      Accessibility checkers show "empty link" errors in system report action links.

      title and aria-label should be added to the link, and aria-hidden to the inner icon.

        1. MDL-73166 WAVE after.png
          MDL-73166 WAVE after.png
          23 kB
        2. MDL-73166 WAVE before.png
          MDL-73166 WAVE before.png
          15 kB
        3. Test accessibility issues are fixed_Screenshot.PNG
          Test accessibility issues are fixed_Screenshot.PNG
          21 kB
        4. Test no regressions were added_Step No. 2_Screenshot.png
          Test no regressions were added_Step No. 2_Screenshot.png
          237 kB
        5. Test no regressions were added_Step No. 4_Screenshot.png
          Test no regressions were added_Step No. 4_Screenshot.png
          218 kB

            mikelmartíncorrales Mikel Martín Corrales
            mikelmartíncorrales Mikel Martín Corrales
            Simey Lameze Simey Lameze
            Jun Pataleta Jun Pataleta
            Gladys Basiana Gladys Basiana
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 day, 21 minutes
                1d 21m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.